Skip to content

Pre commit pospell#37

Merged
gilgamezh merged 2 commits into
3.7from
pre-commit-pospell
May 3, 2020
Merged

Pre commit pospell#37
gilgamezh merged 2 commits into
3.7from
pre-commit-pospell

Conversation

@humitos

@humitos humitos commented May 3, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@humitos humitos requested a review from raulcd May 3, 2020 10:07
Comment thread .pre-commit-config.yaml
hooks:
- id: powrap

# This one requires package ``hunspell-es_es`` in Archlinux

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo agregas al CONTRIBUTING? en telegram @raulcd compartió el nombre de paquete para ubuntu

@gilgamezh gilgamezh self-requested a review May 3, 2020 11:16

@gilgamezh gilgamezh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor actualiza contributing con lo que hace falta instalar

@humitos

humitos commented May 3, 2020

Copy link
Copy Markdown
Collaborator Author

Yo no le complicaría tanto la vida "al público" general. Quizás podemos agregar otra página que explique detalles más técnicos.

Al final, lo que queremos es que la gente traduzca. Luego, si falla el build, lo guíamos para que lo pueda arreglar. Pero me parece mejor si no los enrroscamos a todos con el rollo de estas herramientas por ahora.

@gilgamezh gilgamezh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, estoy de acuerdo en no agregar complejidad para gente nueva

@gilgamezh gilgamezh merged commit 7fb8aeb into 3.7 May 3, 2020
@cmaureir cmaureir deleted the pre-commit-pospell branch August 16, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants