Skip to content

Translate CSV Module rst:71 to rst:152#582

Merged
cschan1828 merged 5 commits into
python:3.12from
rockleona:csv-0806
Aug 15, 2023
Merged

Translate CSV Module rst:71 to rst:152#582
cschan1828 merged 5 commits into
python:3.12from
rockleona:csv-0806

Conversation

@rockleona

Copy link
Copy Markdown
Collaborator

@rockleona

Copy link
Copy Markdown
Collaborator Author

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

@mattwang44

Copy link
Copy Markdown
Collaborator

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

對歐,可以學一下 git rebase 指令怎麼使用,如果不確定怎麼做再請你找我討論 🙏🏽

@mattwang44

mattwang44 commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator

@cschan1828 想請問最近有空來幫忙 review 嗎?

@cschan1828 cschan1828 self-requested a review August 15, 2023 01:23
Comment thread library/csv.po
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated

@cschan1828 cschan1828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit!

有些常見的動詞其實可以考慮直接找中文慣用動詞來用哦,保留原文主要是指專有名詞。

@rockleona

Copy link
Copy Markdown
Collaborator Author

Hi @cschan1828 , thanks for the review!

感謝你的細心,再麻煩幫我看看了,感謝!

Comment thread library/csv.po Outdated

@cschan1828 cschan1828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相當不錯了,僅想再釐清一些小細節。

@cschan1828 cschan1828 enabled auto-merge (squash) August 15, 2023 12:01

@cschan1828 cschan1828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很通用的詞語直接用中文即可。

Comment thread library/csv.po Outdated

@cschan1828 cschan1828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved.

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys!

@cschan1828 cschan1828 merged commit 732575d into python:3.12 Aug 15, 2023
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* Translate rst:71 to rst:152

* Update with Reviewer's comment

* HOTFIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants