Skip to content

Commit 365ed20

Browse files
authored
GHSA/SYNC: 1 new doorkeeper-openid_connect advisory (#1101)
* GHSA/SYNC: 1 new advisory * Add GitLab advisory link for CVE-2026-44476
1 parent 134542d commit 365ed20

1 file changed

Lines changed: 60 additions & 0 deletions

File tree

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
---
2+
gem: doorkeeper-openid_connect
3+
cve: 2026-44476
4+
ghsa: m6vc-f87m-cc2h
5+
url: https://www.cve.org/CVERecord?id=CVE-2026-44476
6+
title: Dynamic Client Registration feature creates public clients
7+
with client_secret
8+
date: 2026-06-04
9+
description: |
10+
### Impact
11+
12+
The `DynamicClientRegistrationController#register` action hard-codes
13+
`confidential: false` when creating applications
14+
(dynamic_client_registration_controller.rb:18-25), yet the response
15+
includes a client_secret and advertises `token_endpoint_auth_methods_supported:
16+
["client_secret_basic", "client_secret_post"]`.
17+
18+
Because Doorkeeper's `Application.by_uid_and_secret` treats a
19+
blank/missing secret as valid for non-confidential (public) clients, an
20+
attacker who knows only the client_id (which is public information)
21+
can authenticate as the dynamically-registered client at the token endpoint.
22+
23+
**Note** that Dynamic Client Registration is opt-in feature which is
24+
disabled by default so only projects that explicitly enabled it are affected.
25+
26+
**Steps to Reproduce**
27+
28+
1. Enable dynamic client registration in the initializer
29+
2. POST /oauth/registration with client_name, redirect_uris, and scope
30+
3. Observe: response returns client_secret, but the created
31+
Doorkeeper::Application has confidential: false
32+
4. Call `Doorkeeper::Application.by_uid_and_secret(client_id, nil)` — it
33+
returns the application (credentials bypass)
34+
5. POST /oauth/token with grant_type=client_credentials and only
35+
client_id (no client_secret) — the token endpoint issues an access token
36+
without any secret verification
37+
38+
### Workarounds
39+
40+
Upgrade existing applications created with a Dynamic Client registration
41+
to have `confidential: true`
42+
cvss_v3: 6.3
43+
unaffected_versions:
44+
- "< 1.9.0"
45+
patched_versions:
46+
- ">= 1.10.0"
47+
related:
48+
url:
49+
- https://www.cve.org/CVERecord/SearchResults?query=CVE-2026-44476
50+
- https://rubygems.org/gems/doorkeeper-openid_connect/versions/1.10.0
51+
- https://github.com/doorkeeper-gem/doorkeeper-openid_connect/releases/tag/v1.10.0
52+
- https://advisories.gitlab.com/gem/doorkeeper-openid_connect/CVE-2026-44476
53+
- https://github.com/doorkeeper-gem/doorkeeper-openid_connect/security/advisories/GHSA-m6vc-f87m-cc2h
54+
- https://github.com/advisories/GHSA-m6vc-f87m-cc2h
55+
notes: |
56+
- Looking for CVE reference:
57+
- https://www.cve.org/CVERecord?id=CVE-2026-44476 (reserved)
58+
- https://nvd.nist.gov/vuln/detail/CVE-2026-44476 (not found)
59+
- https://cve.report/search.php?search=CVE-2026-44476 (not listed)
60+
- https://www.cvedetails.com/index.php (not found; no URL parameter)

0 commit comments

Comments
 (0)