From 624c46793ebf4f77ef1b15dec304414caa853618 Mon Sep 17 00:00:00 2001 From: Emmanuel Zamora Date: Thu, 21 Jul 2022 19:17:36 -0300 Subject: [PATCH 1/2] remove shouldAddPt and always instantiate impressionsObserverFactory --- src/factory/browser.js | 2 +- src/factory/node.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/factory/browser.js b/src/factory/browser.js index 8fbf736b4..7e161426f 100644 --- a/src/factory/browser.js +++ b/src/factory/browser.js @@ -52,7 +52,7 @@ function getModules(settings) { integrationsManagerFactory: settings.integrations && settings.integrations.length > 0 ? integrationsManagerFactory.bind(null, settings.integrations) : undefined, - impressionsObserverFactory: shouldAddPt(settings) ? impressionObserverCSFactory : undefined, + impressionsObserverFactory: impressionObserverCSFactory, extraProps: (params) => { return { diff --git a/src/factory/node.js b/src/factory/node.js index b01a3dfd4..930ce7f92 100644 --- a/src/factory/node.js +++ b/src/factory/node.js @@ -45,7 +45,7 @@ function getModules(settings) { SignalListener, - impressionsObserverFactory: shouldAddPt(settings) ? impressionObserverSSFactory : undefined, + impressionsObserverFactory: impressionObserverSSFactory, }; switch (settings.mode) { From 914d48e72fbafccf32875930e632773feda5de9a Mon Sep 17 00:00:00 2001 From: Emmanuel Zamora Date: Thu, 21 Jul 2022 19:22:05 -0300 Subject: [PATCH 2/2] remove unused imports --- src/factory/browser.js | 1 - src/factory/node.js | 1 - 2 files changed, 2 deletions(-) diff --git a/src/factory/browser.js b/src/factory/browser.js index 7e161426f..9b877a36d 100644 --- a/src/factory/browser.js +++ b/src/factory/browser.js @@ -11,7 +11,6 @@ import { integrationsManagerFactory } from '@splitsoftware/splitio-commons/src/i import { __InLocalStorageMockFactory } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/storage/storageCS'; import { sdkFactory } from '@splitsoftware/splitio-commons/src/sdkFactory'; import { LOCALHOST_MODE, STORAGE_LOCALSTORAGE } from '@splitsoftware/splitio-commons/src/utils/constants'; -import { shouldAddPt } from '@splitsoftware/splitio-commons/src/trackers/impressionObserver/utils'; import { createUserConsentAPI } from '@splitsoftware/splitio-commons/src/consent/sdkUserConsent'; import { settingsFactory } from '../settings/browser'; diff --git a/src/factory/node.js b/src/factory/node.js index 930ce7f92..9eaf65583 100644 --- a/src/factory/node.js +++ b/src/factory/node.js @@ -9,7 +9,6 @@ import { sdkClientMethodFactory } from '@splitsoftware/splitio-commons/src/sdkCl import { impressionObserverSSFactory } from '@splitsoftware/splitio-commons/src/trackers/impressionObserver/impressionObserverSS'; import { sdkFactory } from '@splitsoftware/splitio-commons/src/sdkFactory'; import { CONSUMER_MODE, LOCALHOST_MODE } from '@splitsoftware/splitio-commons/src/utils/constants'; -import { shouldAddPt } from '@splitsoftware/splitio-commons/src/trackers/impressionObserver/utils'; import { settingsFactory } from '../settings/node'; import { platform, SignalListener } from '../platform';