From 1add90768e71f8efa7363e05a49575fb065b67ae Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Thu, 12 Oct 2023 13:21:14 -0700 Subject: [PATCH 1/2] fixed exception when new flagset detected --- splitio/storage/inmemmory.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/splitio/storage/inmemmory.py b/splitio/storage/inmemmory.py index e9291577..b6b317f5 100644 --- a/splitio/storage/inmemmory.py +++ b/splitio/storage/inmemmory.py @@ -92,6 +92,8 @@ def remove_feature_flag_to_flag_set(self, flag_set, feature_flag): :param feature_flag: feature flag name :type feature_flag: str """ + _LOGGER.debug("remove_feature_flag_to_flag_set") + _LOGGER.debug(flag_set) with self._lock: if self.flag_set_exist(flag_set): self.sets_feature_flag_map[flag_set].remove(feature_flag) @@ -200,7 +202,7 @@ def _remove_from_flag_sets(self, feature_flag): if feature_flag.sets is not None: for flag_set in feature_flag.sets: self.flag_set.remove_feature_flag_to_flag_set(flag_set, feature_flag.name) - if len(self.flag_set.get_flag_set(flag_set)) == 0 and not self.flag_set_filter.should_filter: + if self.is_flag_set_exist(flag_set) and len(self.flag_set.get_flag_set(flag_set)) == 0 and not self.flag_set_filter.should_filter: self.flag_set.remove_flag_set(flag_set) def get_feature_flags_by_sets(self, sets): From 576a0f418885e4279c2762e50794201817b449a8 Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Thu, 12 Oct 2023 13:27:14 -0700 Subject: [PATCH 2/2] cleanup --- splitio/storage/inmemmory.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/splitio/storage/inmemmory.py b/splitio/storage/inmemmory.py index b6b317f5..a31cddd4 100644 --- a/splitio/storage/inmemmory.py +++ b/splitio/storage/inmemmory.py @@ -92,8 +92,6 @@ def remove_feature_flag_to_flag_set(self, flag_set, feature_flag): :param feature_flag: feature flag name :type feature_flag: str """ - _LOGGER.debug("remove_feature_flag_to_flag_set") - _LOGGER.debug(flag_set) with self._lock: if self.flag_set_exist(flag_set): self.sets_feature_flag_map[flag_set].remove(feature_flag)