diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 901259f..9f9e226 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,6 +3,8 @@ on: pull_request: branches: - main + pull_request_target: + branches: - development push: branches: @@ -56,7 +58,7 @@ jobs: -Dsonar.links.scm="https://github.com/splitio/${{ github.event.repository.name }}" - name: SonarQube Scan (Pull Request) - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' uses: SonarSource/sonarcloud-github-action@v1.8 env: SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }} diff --git a/.github/workflows/update-license-year.yml b/.github/workflows/update-license-year.yml index 9e58254..13aaac8 100644 --- a/.github/workflows/update-license-year.yml +++ b/.github/workflows/update-license-year.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 diff --git a/README.md b/README.md index 773ee00..e6e0a72 100644 --- a/README.md +++ b/README.md @@ -58,6 +58,7 @@ Split has built and maintains SDKs for: * .NET [Github](https://github.com/splitio/dotnet-client) [Docs](https://help.split.io/hc/en-us/articles/360020240172--NET-SDK) * Android [Github](https://github.com/splitio/android-client) [Docs](https://help.split.io/hc/en-us/articles/360020343291-Android-SDK) +* Angular [Github](https://github.com/splitio/angular-sdk-plugin) [Docs](https://help.split.io/hc/en-us/articles/6495326064397-Angular-utilities) * GO [Github](https://github.com/splitio/go-client) [Docs](https://help.split.io/hc/en-us/articles/360020093652-Go-SDK) * iOS [Github](https://github.com/splitio/ios-client) [Docs](https://help.split.io/hc/en-us/articles/360020401491-iOS-SDK) * Java [Github](https://github.com/splitio/java-client) [Docs](https://help.split.io/hc/en-us/articles/360020405151-Java-SDK) diff --git a/types/splitio.d.ts b/types/splitio.d.ts index 15f25b4..1dede34 100644 --- a/types/splitio.d.ts +++ b/types/splitio.d.ts @@ -1023,14 +1023,14 @@ declare namespace SplitIO { */ setAttribute(attributeName: string, attributeValue: AttributeType): boolean, /** - * Returns the attribute with the given key. + * Returns the attribute with the given name. * * @param {string} attributeName Attribute name - * @returns {AttributeType} Attribute with the given key + * @returns {AttributeType} Attribute with the given name */ getAttribute(attributeName: string): AttributeType, /** - * Removes from client's in memory attributes storage the attribute with the given key. + * Removes from client's in memory attributes storage the attribute with the given name. * * @param {string} attributeName * @returns {boolean} true if attribute was removed and false otherwise