Skip to content

fix: readd Hive 4.0.0#1031

Merged
razvan merged 2 commits into
mainfrom
fix/hive400
Mar 18, 2025
Merged

fix: readd Hive 4.0.0#1031
razvan merged 2 commits into
mainfrom
fix/hive400

Conversation

@razvan

@razvan razvan commented Mar 17, 2025

Copy link
Copy Markdown
Member

Description

As discussed here, Hive 4.0.1 removes functions that break python-iceberg.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan self-assigned this Mar 17, 2025
@razvan razvan requested a review from a team March 17, 2025 15:42
@nightkr

nightkr commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Do we have an issue/rationale for this somewhere? (Not saying there is none, but so we know when we can safely remove it again.)

You'll probably also want to restore the patches as well.

@razvan

razvan commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Do we have an issue/rationale for this somewhere? (Not saying there is none, but so we know when we can safely remove it again.)

Yes, in the linked pr.

You'll probably also want to restore the patches as well.

Of course, silly me.

@razvan razvan marked this pull request as draft March 17, 2025 15:58
@razvan

razvan commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 9566b78 Mar 18, 2025
@razvan razvan deleted the fix/hive400 branch March 18, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants