feat: add `lapack/base/disnan` by iampratik13 · Pull Request #12289 · stdlib-js/stdlib

iampratik13 · 2026-05-25T20:09:45Z

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

feat: add lapack/base/disnan

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Needs feat: add lapack/base/dlaisnan #12183 to be merged.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

kgryte · 2026-05-31T23:52:24Z

+// TypeScript Version: 4.1
+
+/**
+* Tests a double-precision floating-point numeric value for NaN.


Suggested change

* Tests a double-precision floating-point numeric value for NaN.

* Tests whether a double-precision floating-point number is NaN.

kgryte · 2026-05-31T23:52:37Z

+/**
+* Tests a double-precision floating-point numeric value for NaN.
+*
+* @param DIN - double-precision floating-point number to test


Suggested change

* @param DIN - double-precision floating-point number to test

* @param x - input value

kgryte · 2026-05-31T23:52:45Z

+* Tests a double-precision floating-point numeric value for NaN.
+*
+* @param DIN - double-precision floating-point number to test
+* @returns boolean indicating whether the value is NaN


Suggested change

* @returns boolean indicating whether the value is NaN

* @returns boolean indicating whether an input value is NaN

kgryte · 2026-05-31T23:53:04Z

+* var bool = disnan( 5.0 );
+* // returns false
+*/
+declare function disnan( DIN: number ): boolean;


Suggested change

declare function disnan( DIN: number ): boolean;

declare function disnan( x: number ): boolean;

Use normal JavaScript parameter names.

kgryte · 2026-05-31T23:53:23Z

@@ -0,0 +1,24 @@
+
+{{alias}}( din )


All the same comments.

kgryte · 2026-05-31T23:53:54Z

+'use strict';
+
+/**
+* LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.


Suggested change

* LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.

* LAPACK auxiliary routine to test whether a double-precision floating-point number is NaN.

kgryte · 2026-05-31T23:54:16Z

+* ## Notes
+*
+* -   This routine uses `dlaisnan` to test for `NaN` by comparing the argument against itself for inequality.
+*


Suggested change

* ## Notes

*

* - This routine uses `dlaisnan` to test for `NaN` by comparing the argument against itself for inequality.

*

stdlib-bot · 2026-05-31T23:54:28Z

Coverage Report

Package	Statements	Branches	Functions	Lines
lapack/base/disnan	$\color{green}96/96$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}96/96$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte · 2026-05-31T23:54:30Z

+// MAIN //
+
+/**
+* Tests a double-precision floating-point numeric value for NaN.


All the same comments.

kgryte · 2026-05-31T23:55:09Z

+{
+  "name": "@stdlib/lapack/base/disnan",
+  "version": "0.0.0",
+  "description": "LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.",


Suggested change

"description": "LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.",

"description": "LAPACK auxiliary routine to test whether a double-precision floating-point number is NaN.",

kgryte · 2026-05-31T23:55:32Z

+
+# disnan
+
+> LAPACK auxiliary routine to test a double-precision floating-point numeric value for `NaN`.


Suggested change

> LAPACK auxiliary routine to test a double-precision floating-point numeric value for `NaN`.

> LAPACK auxiliary routine to test whether a double-precision floating-point number is `NaN`.

kgryte · 2026-05-31T23:55:43Z

+var disnan = require( '@stdlib/lapack/base/disnan' );
+```
+
+#### disnan( din )


All the same comments.

kgryte · 2026-05-31T23:56:11Z

+## Notes
+
+-   `disnan()` corresponds to the [LAPACK][lapack] auxiliary routine [`disnan`][lapack-disnan].
+-   `disnan` tests for `NaN` by internally calling [`dlaisnan`][lapack-dlaisnan] with the same argument passed twice (i.e., `dlaisnan( din, din )`). This approach avoids issues with compiler optimization that might incorrectly evaluate `NaN !== NaN` as `false`.


Suggested change

- `disnan` tests for `NaN` by internally calling [`dlaisnan`][lapack-dlaisnan] with the same argument passed twice (i.e., `dlaisnan( din, din )`). This approach avoids issues with compiler optimization that might incorrectly evaluate `NaN !== NaN` as `false`.

This info isn't super relevant for the average user.

kgryte

Similar to dlaisnan, I am not convinced that this package is particularly relevant/necessary for our JavaScript implementations where we can (and likely should) just use math/base/assert/is-nan. It becomes more relevant for the C and Fortran implementations.

Left a number of initial comments.

feat: add lapack/base/disnan

c687a01

iampratik13 requested a review from a team May 25, 2026 20:09

stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels May 25, 2026

iampratik13 marked this pull request as draft May 25, 2026 20:13

stdlib-bot removed the Needs Review A pull request which needs code review. label May 25, 2026

iampratik13 mentioned this pull request May 27, 2026

Weekly Standup (2026-05-25) stdlib-js/meetings#127

Open

Merge branch 'develop' into lapack/disnan

124c761

kgryte added Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels May 31, 2026

kgryte marked this pull request as ready for review May 31, 2026 23:51

stdlib-bot added the Needs Review A pull request which needs code review. label May 31, 2026

kgryte reviewed May 31, 2026

View reviewed changes

kgryte requested changes May 31, 2026

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 31, 2026

	* Tests a double-precision floating-point numeric value for NaN.
	* Tests whether a double-precision floating-point number is NaN.

	* @param DIN - double-precision floating-point number to test
	* @param x - input value

	* @returns boolean indicating whether the value is NaN
	* @returns boolean indicating whether an input value is NaN

	declare function disnan( DIN: number ): boolean;
	declare function disnan( x: number ): boolean;

	* LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.
	* LAPACK auxiliary routine to test whether a double-precision floating-point number is NaN.

	"description": "LAPACK auxiliary routine to test a double-precision floating-point numeric value for NaN.",
	"description": "LAPACK auxiliary routine to test whether a double-precision floating-point number is NaN.",


		# disnan

		> LAPACK auxiliary routine to test a double-precision floating-point numeric value for `NaN`.

	> LAPACK auxiliary routine to test a double-precision floating-point numeric value for `NaN`.
	> LAPACK auxiliary routine to test whether a double-precision floating-point number is `NaN`.

Uh oh!

Conversation

iampratik13 commented May 25, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented May 31, 2026

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kgryte May 31, 2026 •

edited

Loading