Skip to content

Commit 57639be

Browse files
charleskeepaxplbossart
authored andcommitted
ASoC: intel: sof_sdw: Increment be_id in init_dai_link
Rather than incrementing the ID for the dai_links in many places throughout the code, just increment it each time we initialise a new DAI link. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
1 parent c4b74e9 commit 57639be

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

sound/soc/intel/boards/sof_sdw.c

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ static int quirk_override = -1;
2020
module_param_named(quirk, quirk_override, int, 0444);
2121
MODULE_PARM_DESC(quirk, "Board-specific quirk override");
2222

23-
#define INC_ID(BE, LINK) do { (BE)++; (LINK)++; } while (0)
24-
2523
static void log_quirks(struct device *dev)
2624
{
2725
if (SOF_JACK_JDSRC(sof_sdw_quirk))
@@ -1099,14 +1097,14 @@ static int get_dailink_info(struct device *dev,
10991097
}
11001098

11011099
static void init_dai_link(struct device *dev, struct snd_soc_dai_link *dai_links,
1102-
int be_id, char *name, int playback, int capture,
1100+
int *be_id, char *name, int playback, int capture,
11031101
struct snd_soc_dai_link_component *cpus, int cpus_num,
11041102
struct snd_soc_dai_link_component *codecs, int codecs_num,
11051103
int (*init)(struct snd_soc_pcm_runtime *rtd),
11061104
const struct snd_soc_ops *ops)
11071105
{
1108-
dev_dbg(dev, "create dai link %s, id %d\n", name, be_id);
1109-
dai_links->id = be_id;
1106+
dev_dbg(dev, "create dai link %s, id %d\n", name, *be_id);
1107+
dai_links->id = (*be_id)++;
11101108
dai_links->name = name;
11111109
dai_links->platforms = platform_component;
11121110
dai_links->num_platforms = ARRAY_SIZE(platform_component);
@@ -1122,7 +1120,7 @@ static void init_dai_link(struct device *dev, struct snd_soc_dai_link *dai_links
11221120
}
11231121

11241122
static int init_simple_dai_link(struct device *dev, struct snd_soc_dai_link *dai_links,
1125-
int be_id, char *name, int playback, int capture,
1123+
int *be_id, char *name, int playback, int capture,
11261124
const char *cpu_dai_name,
11271125
const char *codec_name, const char *codec_dai_name,
11281126
int (*init)(struct snd_soc_pcm_runtime *rtd),
@@ -1494,7 +1492,7 @@ static int create_sdw_dailink(struct snd_soc_card *card, int *link_index,
14941492
playback = (stream == SNDRV_PCM_STREAM_PLAYBACK);
14951493
capture = (stream == SNDRV_PCM_STREAM_CAPTURE);
14961494

1497-
init_dai_link(dev, dai_links + *link_index, (*be_id)++, name,
1495+
init_dai_link(dev, dai_links + *link_index, be_id, name,
14981496
playback, capture, cpus, cpu_dai_num, codecs, codec_num,
14991497
NULL, &sdw_ops);
15001498

@@ -1684,7 +1682,7 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
16841682
playback = info->dais[0].direction[SNDRV_PCM_STREAM_PLAYBACK];
16851683
capture = info->dais[0].direction[SNDRV_PCM_STREAM_CAPTURE];
16861684

1687-
ret = init_simple_dai_link(dev, dai_links + link_index, be_id, name,
1685+
ret = init_simple_dai_link(dev, dai_links + link_index, &be_id, name,
16881686
playback, capture, cpu_dai_name,
16891687
codec_name, info->dais[0].dai_name,
16901688
NULL, info->ops);
@@ -1695,7 +1693,7 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
16951693
if (ret < 0)
16961694
return ret;
16971695

1698-
INC_ID(be_id, link_index);
1696+
link_index++;
16991697
}
17001698

17011699
DMIC:
@@ -1706,24 +1704,24 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
17061704
goto HDMI;
17071705
}
17081706

1709-
ret = init_simple_dai_link(dev, dai_links + link_index, be_id, "dmic01",
1707+
ret = init_simple_dai_link(dev, dai_links + link_index, &be_id, "dmic01",
17101708
0, 1, // DMIC only supports capture
17111709
"DMIC01 Pin", "dmic-codec", "dmic-hifi",
17121710
sof_sdw_dmic_init, NULL);
17131711
if (ret)
17141712
return ret;
17151713

1716-
INC_ID(be_id, link_index);
1714+
link_index++;
17171715

1718-
ret = init_simple_dai_link(dev, dai_links + link_index, be_id, "dmic16k",
1716+
ret = init_simple_dai_link(dev, dai_links + link_index, &be_id, "dmic16k",
17191717
0, 1, // DMIC only supports capture
17201718
"DMIC16k Pin", "dmic-codec", "dmic-hifi",
17211719
/* don't call sof_sdw_dmic_init() twice */
17221720
NULL, NULL);
17231721
if (ret)
17241722
return ret;
17251723

1726-
INC_ID(be_id, link_index);
1724+
link_index++;
17271725
}
17281726

17291727
HDMI:
@@ -1741,14 +1739,14 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
17411739
codec_dai_name = "snd-soc-dummy-dai";
17421740
}
17431741

1744-
ret = init_simple_dai_link(dev, dai_links + link_index, be_id, name,
1742+
ret = init_simple_dai_link(dev, dai_links + link_index, &be_id, name,
17451743
1, 0, // HDMI only supports playback
17461744
cpu_dai_name, codec_name, codec_dai_name,
17471745
sof_sdw_hdmi_init, NULL);
17481746
if (ret)
17491747
return ret;
17501748

1751-
INC_ID(be_id, link_index);
1749+
link_index++;
17521750
}
17531751

17541752
if (sof_sdw_quirk & SOF_SSP_BT_OFFLOAD_PRESENT) {
@@ -1758,7 +1756,7 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
17581756
name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d-BT", port);
17591757
cpu_dai_name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d Pin", port);
17601758

1761-
ret = init_simple_dai_link(dev, dai_links + link_index, be_id, name,
1759+
ret = init_simple_dai_link(dev, dai_links + link_index, &be_id, name,
17621760
1, 1, cpu_dai_name, asoc_dummy_dlc.name,
17631761
asoc_dummy_dlc.dai_name, NULL, NULL);
17641762
if (ret)

0 commit comments

Comments
 (0)