Skip to content

libffi: update to 3.5.2 (let's try this again!)#59704

Draft
amadaluzia wants to merge 60 commits into
void-linux:masterfrom
amadaluzia:libffi
Draft

libffi: update to 3.5.2 (let's try this again!)#59704
amadaluzia wants to merge 60 commits into
void-linux:masterfrom
amadaluzia:libffi

Conversation

@amadaluzia

@amadaluzia amadaluzia commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: NO

[ci skip]

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

Additional notes

I have currently only built libffi. I have yet to build the other bumped packages. I'm currently writing a script to build them all, although I doubt it'll be finished even after the afternoon (it's 5:10 at the moment, and I have not slept yet).

I also want to say that @JkktBkkt has been really helpful with building things on my behalf and updating me on how things are going regarding the status of said packages, I cannot thank them enough for the work that they've put in to helping the PR get this far, but I do want to state my gratitude at least.

@oreo639 oreo639 marked this pull request as draft April 2, 2026 06:17
@amadaluzia amadaluzia force-pushed the libffi branch 4 times, most recently from 87917ae to 43e4800 Compare April 3, 2026 19:56
Comment thread srcpkgs/libffi/template Outdated
@amadaluzia amadaluzia force-pushed the libffi branch 6 times, most recently from 9b0dd8c to 1ab9910 Compare April 9, 2026 11:57
@amadaluzia amadaluzia force-pushed the libffi branch 2 times, most recently from aa9109d to c15de40 Compare May 8, 2026 18:35
@amadaluzia amadaluzia force-pushed the libffi branch 4 times, most recently from f1476d2 to 8f62e76 Compare May 15, 2026 17:15
@amadaluzia amadaluzia force-pushed the libffi branch 2 times, most recently from 56617fa to 8c5cf1f Compare May 27, 2026 03:59

@JkktBkkt JkktBkkt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few empty commits too, i.e. glib here: 578e206

These aren't exhaustive, I still haven't tried building most packages, will be attempting those in the upcoming days

Comment thread srcpkgs/libffi/template Outdated
Comment thread srcpkgs/ghc/patches/sphinx-indent-workaround.patch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be marked as a "Git LFS" file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why or who made it an LFS file but I'm hoping it had a reason.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW it's not marked as LFS on master: https://github.com/void-linux/void-packages/blob/master/srcpkgs/git-mediate/template (notice the preview existing)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what happened on my end then. I'll revert that.

Comment thread srcpkgs/hledger/template
Comment thread srcpkgs/llvm21/template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something needs to be done to libcxx, libcxxabi, libunwind and their -devel — those symlinks point to llvm22 instead, so while build just fine, the installation phase fails.

For testing purposes I temporarily swapped these to llvm21 and after building it, back to llvm22.

With that, both llvm21 and llvm22 packaged just fine:

  • x86_64
  • x86_64-musl
  • i686
  • armv6l *
  • armv6l-musl *
  • armv7l *
  • armv7l-musl *
  • aarch64 *
  • aarch64-musl *

Using * to mark cross

Comment thread srcpkgs/lua54-lgi/template
Comment thread srcpkgs/mozjs115/template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate it out
Might make sense to update, 115.36.0 built fine.
Or remove the package altogether — the only template depending on it is 0ad, and upstream moved to mozjs128 instead now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated, just haven't updated it yet. It's worth it's own pull request.

Comment thread srcpkgs/mozjs128/template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message doesn't fit
Currently mozjs128 fails while running testsuite.
Can be solved by updating, i.e. to v128.14.0 and dropping 019-python-3.11.patch which has been merged by upstream.
With that, built fine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the commit message, the update should be it's own PR.

Comment thread srcpkgs/mozjs140/template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the commit message, this should also be it's own PR.

Comment thread srcpkgs/libffi/template Outdated
Comment thread srcpkgs/p11-kit/template

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: p11-kit fails in 2 tests when running with XBPS_CHROOT_CMD=uunshare, but builds and runs the test suite without failure with XBPS_CHROOT_CMD=uchroot
This is observable on master too.

@amadaluzia amadaluzia force-pushed the libffi branch 2 times, most recently from 8520e1a to 39abf3c Compare May 31, 2026 07:27
Comment thread srcpkgs/micropython/template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants