From 2193d6625e3a25087d38b6a92a6edb75acaa2d17 Mon Sep 17 00:00:00 2001 From: Anshuman Verma Date: Tue, 6 Oct 2020 19:37:47 +0530 Subject: [PATCH 1/2] feat: bump CI Node to 14 --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index ab6da2a3901..db7eada617b 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -56,7 +56,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [10.x, 12.x, 13.x] + node-version: [10.x, 12.x, 14.x] webpack-version: [next, latest] steps: From be2e3915de91bafa02c5b85deb7a03d4d16654ab Mon Sep 17 00:00:00 2001 From: Anshuman Verma Date: Wed, 7 Oct 2020 17:37:24 +0530 Subject: [PATCH 2/2] fix: tests --- test/node/node.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/node/node.test.js b/test/node/node.test.js index d922b3fb61b..9807d8d13ed 100644 --- a/test/node/node.test.js +++ b/test/node/node.test.js @@ -29,7 +29,7 @@ describe('node flags', () => { it('throws an error if no values were supplied with --max-old-space-size', async () => { const { stderr, stdout } = await run(__dirname, [], false, ['--max-old-space-size']); - expect(stderr).toContain('missing value for flag --max-old-space-size'); + expect(stderr).toContain('value for flag --max-old-space-size'); expect(stdout).toBeFalsy(); });