feat(generated): Pipes, PipesProvider, UserManagement (batch 6c21f6dc) - #425
Conversation
| ?bool $enabled = null, | ||
| ?array $scopes = null, | ||
| ?array $authMethods = null, | ||
| ?array $config = null, |
There was a problem hiding this comment.
Positional argument binding breaks
When existing consumers pass credentials or request options positionally, the new config parameter captures the former argument position with an incompatible ?array type, causing previously valid calls to throw TypeError. The same breaking insertion occurs in authorizeDataIntegration and PipesProvider::updateOrganizationDataIntegrationConfiguration.
Knowledge Base Used: ClientApi and Pipes services
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 78
Comment:
**Positional argument binding breaks**
When existing consumers pass credentials or request options positionally, the new `config` parameter captures the former argument position with an incompatible `?array` type, causing previously valid calls to throw `TypeError`. The same breaking insertion occurs in `authorizeDataIntegration` and `PipesProvider::updateOrganizationDataIntegrationConfiguration`.
**Knowledge Base Used:** [ClientApi and Pipes services](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/client-api-and-pipes.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Greptile SummaryRegenerates the Pipes SDK models and services for provider configuration and client-credentials response values.
Confidence Score: 3/5The PR should not merge until the new config parameters stop rebinding previously valid positional calls. Three public service signatures insert config before existing typed arguments, causing established positional call shapes to fail with TypeError before sending their requests. Files Needing Attention: lib/Service/Pipes.php and lib/Service/PipesProvider.php Important Files Changed
Prompt To Fix All With AI### Issue 1
lib/Service/Pipes.php:78
**Config insertion breaks positional calls**
When existing consumers pass credentials or request options positionally, the new `config` parameter captures the value intended for the former parameter, causing PHP to throw a `TypeError` before the API request is sent. The same parameter shift affects `authorizeDataIntegration` and `PipesProvider::updateOrganizationDataIntegrationConfiguration`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
| ?bool $enabled = null, | ||
| ?array $scopes = null, | ||
| ?array $authMethods = null, | ||
| ?array $config = null, |
There was a problem hiding this comment.
Config insertion breaks positional calls
When existing consumers pass credentials or request options positionally, the new config parameter captures the value intended for the former parameter, causing PHP to throw a TypeError before the API request is sent. The same parameter shift affects authorizeDataIntegration and PipesProvider::updateOrganizationDataIntegrationConfiguration.
Knowledge Base Used: ClientApi and Pipes services
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 78
Comment:
**Config insertion breaks positional calls**
When existing consumers pass credentials or request options positionally, the new `config` parameter captures the value intended for the former parameter, causing PHP to throw a `TypeError` before the API request is sent. The same parameter shift affects `authorizeDataIntegration` and `PipesProvider::updateOrganizationDataIntegrationConfiguration`.
**Knowledge Base Used:** [ClientApi and Pipes services](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/client-api-and-pipes.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Regenerated SDK from spec changes.
Triggered by workos/openapi-spec@72f2c0b