added skip permission from main sdk to port#11
Closed
tilakpatell wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the contribution @tilakpatell! Great catch on the missing parity for The core functionality (fields + wire serialization) was independently added as part of a broader v0.1.49 parity sync, but your PR identified the missing fluent setters ( I've incorporated the fluent setter pattern from your PR in commit 7dc023d with a |
Owner
|
Closing as the changes have been incorporated (see comment above). Thanks again! |
0xeb
added a commit
that referenced
this pull request
Jun 9, 2026
…_in_tool Add ref-qualified with_skip_permission() and with_overrides_built_in_tool() fluent setters enabling chaining on make_tool() and ToolBuilder results. Closes #11 Co-authored-by: Tilak Patel <tilakny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official Python and TypeScript SDKs support
skip_permissionandoverrides_built_in_toolon tool definitions (Python docs), but the C++ port doesn't include them yet. This PR adds parity for both.Changes
include/copilot/types.hpp— Addedskip_permissionandoverrides_built_in_toolbool fields tostruct Tool(defaultfalse), plus ref-qualified fluent setters for chainingsrc/client.cpp—build_session_create_requestandbuild_session_resume_requestnow includeskipPermissionandoverridesBuiltInToolin the JSON-RPC tool payload whentrueUsage
Fully backward compatible — both fields default to
false, no existing code affected.