fix: MCP node should not mark all params required when schema has no required (#6955) - #7086
Merged
liuruibin merged 1 commit intoSep 18, 2026
Merged
Conversation
When inputSchema has no required field (or it is empty), optional chaining made `undefined !== -1` true and marked every param required. Default missing/empty required to [] so params stay optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputSchema/args_schemaomitsrequired(or uses[]), the MCP workflow node incorrectly treated every parameter as required.args_schema.required?.indexOf(item) !== -1evaluates totruewhenrequiredis missing (undefined !== -1).requiredto[]for both top-level and nested property schemas so only explicitly listed fields are required.Test plan
required(e.g. SQLBotmcp_start)*token) — should succeedrequired: ["foo"], onlyfooshows as required and validation still enforces it