fix(security): SEC-619 raise minimum deployment target to iOS 17#49
Open
juwoncube wants to merge 1 commit into
Open
fix(security): SEC-619 raise minimum deployment target to iOS 17#49juwoncube wants to merge 1 commit into
juwoncube wants to merge 1 commit into
Conversation
Pen test flagged EOL minimum OS versions in embedded frameworks. Raise IPHONEOS_DEPLOYMENT_TARGET, SPM platform, and podspec deployment target to iOS 17.0. Bump version to 4.2.1.
juwoncube
requested review from
3scsamdavis,
JonValijonov,
Szuyun-3SC and
neil3sidedcube
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pen test (SEC-619) flags EOL minimum OS versions in embedded frameworks of the Blood iOS app. This is one of 8 3SC frameworks being raised to a minimum deployment target of iOS 17.0.
What changed
IPHONEOS_DEPLOYMENT_TARGET: 16.0 → 17.0 (all 6 occurrences inproject.pbxproj; macOS settings untouched)Package.swift:.iOS(.v16)→.iOS(.v17)MessageStackView.podspec:s.ios.deployment_target14.0 → 17.0,s.version3.0.0 → 4.2.1 (was stale)MARKETING_VERSION: 4.2.0 → 4.2.1Build & test results
xcodebuild build(schemeMessageStackView, generic/platform=iOS): BUILD SUCCEEDEDxcodebuild test(schemeMessageStackViewTests, iPhone 17 simulator): TEST SUCCEEDED — 6 tests, 0 failuresNew warnings introduced by the bump
None. Existing deprecation warnings (
UIApplication.windowsandUIButton.contentEdgeInsets, both deprecated in iOS 15) were already emitted at the previous 16.0 target and are unchanged. Remaining warnings are pre-existing SwiftLint findings.Note for consumers
Consumer apps must target iOS >= 17.0 to adopt this version.