Add SwiftUI toast posting support#50
Open
Szuyun-3SC wants to merge 8 commits into
Open
Conversation
Allow consumers to post SwiftUI views through the existing PostManager machinery (HostingMessageView + Poster.post(_:)) and to replace the default no-internet MessageView via customViewProvider, so apps can restyle connectivity toasts without forking the framework (ARCBLOOD-4146). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The previous restructure commit moved Reachability.m, SwizzledMethod.m and UIViewController+Lifecycle.m into Sources/MessageStackViewObjC/ and the Swift sources into Sources/MessageStackView/, but the manifest still declared a single MessageStackView target with path "Sources" containing both. Xcode rejected the package with `target at '.../Sources' contains mixed language source files; feature not supported`. This commit declares the two targets at their actual paths and processes the asset catalogues.
AI-assistant: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AI-assistant: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Temporary diagnostic logs to verify reachability events fire and the custom view path is hit (ARCBLOOD-4146). Revert before merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Szuyun-3SC
requested review from
3scsamdavis,
JonValijonov,
juwoncube and
neil3sidedcube
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
HostingMessageViewwraps SwiftUI content so it can be posted on aPoster, with a trailing@ViewBuilderpostAPI and aPostRequestinit for SwiftUI contentpostdismissAfterto.defaultMessageDismiss(5s) so toasts auto-dismiss like the other message APIscustomViewProvider) toConnectivityManager.MessageManagerSourcesinto a two-target SPM layoutWhy?
ARCBLOOD-4146
Toasts on iOS need to be built with SwiftUI views; this adds first-class SwiftUI posting to MessageStackView so the app can post toast content directly.
Screenshots / Recording?
Recording to be added by author.