docs(next): point drive runs at #174 instead of human-blocked work - #210
Conversation
…ial work The previous package named the review-swarm credential. That work is real and it is blocked on a repository administrator: minting a Cloud credential and storing an Actions secret are not agent-permitted, and the Lead may not edit the gate that judges its work. Four consecutive drive runs read it, correctly concluded they were blocked, and each produced a NEEDS_HUMAN saying so — #199, #202, #207, #208. That is four cycles spent re-deriving one fact. A package that names human-blocked work turns every run into a report. #174 is the opposite: a real intermittent hang in crash-resume, reopened today with fresh evidence, needing no credential and no gate access. It reproduces at roughly one run in eight on main, which makes it tractable by repetition rather than by insight. The package carries the evidence a run needs and the trap that made this look like a regression: the failure rate did not change when seven commits landed in ten minutes, the sample size did. A shell-only commit failed while the next passed with identical kernel code. Definition of done requires proving a fix by repetition and explicitly permits stopping if it cannot be reproduced, because a hang nobody reproduced is not fixed by a change nobody can test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
in #210 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="ops/NEXT.md">
<violation number="1" location="ops/NEXT.md:32">
P3: The prose says "Line 121 is the `no step.dispatch after resume` path", but at current head the `panic!` emitting that message is on line 122 (`llm.rs:122`), and line 121 is the `Ok(dispatch) => dispatch,` success branch. The quoted stack trace (`llm.rs:121:27`) is from a past run and is fine as quoted evidence, but the present-tense instruction will point an agent at the wrong branch. Drop the hard-coded line number (or fix it to 122) so the dock-up line and the actual panic site agree.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| Also landed: #203 (whole-line verdict matching, `jq -er` on the poll response), | ||
| #202 (a missing reviews directory yields `MISSING` rather than a `find` error). | ||
| Line 121 is the `no step.dispatch after resume` path — the worker never receives |
There was a problem hiding this comment.
P3: The prose says "Line 121 is the no step.dispatch after resume path", but at current head the panic! emitting that message is on line 122 (llm.rs:122), and line 121 is the Ok(dispatch) => dispatch, success branch. The quoted stack trace (llm.rs:121:27) is from a past run and is fine as quoted evidence, but the present-tense instruction will point an agent at the wrong branch. Drop the hard-coded line number (or fix it to 122) so the dock-up line and the actual panic site agree.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At ops/NEXT.md, line 32:
<comment>The prose says "Line 121 is the `no step.dispatch after resume` path", but at current head the `panic!` emitting that message is on line 122 (`llm.rs:122`), and line 121 is the `Ok(dispatch) => dispatch,` success branch. The quoted stack trace (`llm.rs:121:27`) is from a past run and is fine as quoted evidence, but the present-tense instruction will point an agent at the wrong branch. Drop the hard-coded line number (or fix it to 122) so the dock-up line and the actual panic site agree.</comment>
<file context>
@@ -1,85 +1,84 @@
-Also landed: #203 (whole-line verdict matching, `jq -er` on the poll response),
-#202 (a missing reviews directory yields `MISSING` rather than a `find` error).
+Line 121 is the `no step.dispatch after resume` path — the worker never receives
+a dispatch after the daemon is SIGKILLed and resumed. The comment above it
+already attributes this to #174 and captures a daemon-state dump precisely
</file context>
| Line 121 is the `no step.dispatch after resume` path — the worker never receives | |
| The `no step.dispatch after resume` path is the panic that the comment above it attributes to #174 — the worker never receives |
…merged Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
ops/NEXT.mdcurrently points at the review-swarm credential. I wrote that package, and it has produced a loop.Four consecutive drive runs have read it, correctly concluded they are blocked, and each written a
NEEDS_HUMANsaying so — #199, #202, #207, #208. Minting a Cloud credential and storing an Actions secret are not agent-permitted, and the Lead additionally may not edit the gate that judges its work. So every run turns into a report about being unable to run.That is four cycles spent re-deriving one fact, and it is my fault for aiming the package at work no agent can finish.
What this points at instead
#174 —
llm::sigkill_sweep_covers_before_and_between_the_rung_b_stepshangs intermittently, reopened today with fresh evidence:No credential, no gate access, kernel-only. And it reproduces at roughly one in eight, so it is tractable by repetition rather than by insight.
The package carries the trap that made this look like a regression earlier today: the failure rate did not change when seven commits landed within ten minutes — the sample size did. A shell-only commit failed while the very next commit passed with identical kernel code. Without that context a run would spend its cycle bisecting a regression that does not exist.
Definition of done requires proving a fix by repetition (30 consecutive runs), and explicitly permits stopping if it cannot be reproduced, because a hang nobody reproduced is not fixed by a change nobody can test.
Collision note
ops/NEXT.mdis also rewritten by #208, andops/NEEDS_HUMAN.mdby both #207 and #208. Those two disagree with each other on the credential design, so they need reconciling regardless; this PR changes onlyNEXT.mdand takes no position on that argument.The credential decision is still open and still the thing blocking gate 3 — this just stops drive runs from rediscovering that four more times while it waits.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR