fix(workflows): drive sync guard still required the pre-#205 sdk/ path - #211
Merged
Conversation
Both drive flows open by asserting the repo is materialized before doing
anything, and the assertion listed a bare `sdk`:
for required in AGENTS.md docs/RFC-0001-... ops/DIRECTIVES.md kernel sdk; do
#205 moved that tree to `packages/sdk`. It updated the fourteen other
`packages/` references in drive.yaml and missed this one, because the path
appears here as a bare word in a shell for-loop list rather than as a
`sdk/`-prefixed path — the same shape as the nine stale references that PR
already had to chase.
The effect is that the guard fires on a correctly materialized repository and
both drive flows abort at step one with SYNC_FAIL_NOT_MATERIALIZED, which
reads as an infrastructure failure rather than a stale literal. Measured on
main @ de43f9e:
old guard -> SYNC_FAIL_NOT_MATERIALIZED — missing: sdk
new guard -> passes
drive-cloud.yaml carries the same script as an escaped YAML scalar and needed
the identical change; both files still parse.
This matters beyond the two files: `flows-drive` is how the repo implements
RFC-0001 on itself (§2, "rewrite relayflows using relayflows"). While its
first step fails closed, the dogfooding loop cannot run at all.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR
Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both drive flows abort at step one on current
main.Their materialization guard lists a bare
sdk:#205 moved that tree to
packages/sdk. It updated the other fourteenpackages/references indrive.yamland missed this one — the path appears as a bare word in a shell for-loop list, not as asdk/-prefixed path, which is exactly the shape that made the nine stale references in that PR so hard to find.Measured on
main@de43f9e:So a correctly materialized checkout is rejected, and the failure presents as missing infrastructure rather than a stale literal — the guard's message points the reader at
agent-relay cloud run --no-sync-code, which is not the problem.drive-cloud.yamlembeds the same script as an escaped YAML scalar and needed the identical edit. Both files still parse.Why this is worth fixing before anything else
flows-driveis how this repo implements RFC-0001 on itself — §2, "the method: rewrite relayflows using relayflows". Its lead/builder/adversary DAG is the intended vehicle for gate work. While its first step fails closed, that loop cannot run, and gate progress falls back to hand-driven sessions.Scope is two literals. I did not touch the verify steps, which were migrated correctly.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR