Skip to content

fix(workflows): drive sync guard still required the pre-#205 sdk/ path - #211

Merged
kjgbot merged 1 commit into
mainfrom
fix/drive-sync-guard-packages-path
Sep 6, 2026
Merged

fix(workflows): drive sync guard still required the pre-#205 sdk/ path#211
kjgbot merged 1 commit into
mainfrom
fix/drive-sync-guard-packages-path

Conversation

@kjgbot

@kjgbot kjgbot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Both drive flows abort at step one on current main.

Their materialization guard lists a bare sdk:

for required in AGENTS.md docs/RFC-0001-everything-is-a-relayflow.md ops/DIRECTIVES.md kernel sdk; do

#205 moved that tree to packages/sdk. It updated the other fourteen packages/ references in drive.yaml and missed this one — the path appears as a bare word in a shell for-loop list, not as a sdk/-prefixed path, which is exactly the shape that made the nine stale references in that PR so hard to find.

Measured on main @ de43f9e:

old guard -> SYNC_FAIL_NOT_MATERIALIZED — missing: sdk
new guard -> passes

So a correctly materialized checkout is rejected, and the failure presents as missing infrastructure rather than a stale literal — the guard's message points the reader at agent-relay cloud run --no-sync-code, which is not the problem.

drive-cloud.yaml embeds the same script as an escaped YAML scalar and needed the identical edit. Both files still parse.

Why this is worth fixing before anything else

flows-drive is how this repo implements RFC-0001 on itself — §2, "the method: rewrite relayflows using relayflows". Its lead/builder/adversary DAG is the intended vehicle for gate work. While its first step fails closed, that loop cannot run, and gate progress falls back to hand-driven sessions.

Scope is two literals. I did not touch the verify steps, which were migrated correctly.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR

Both drive flows open by asserting the repo is materialized before doing
anything, and the assertion listed a bare `sdk`:

    for required in AGENTS.md docs/RFC-0001-... ops/DIRECTIVES.md kernel sdk; do

#205 moved that tree to `packages/sdk`. It updated the fourteen other
`packages/` references in drive.yaml and missed this one, because the path
appears here as a bare word in a shell for-loop list rather than as a
`sdk/`-prefixed path — the same shape as the nine stale references that PR
already had to chase.

The effect is that the guard fires on a correctly materialized repository and
both drive flows abort at step one with SYNC_FAIL_NOT_MATERIALIZED, which
reads as an infrastructure failure rather than a stale literal. Measured on
main @ de43f9e:

    old guard -> SYNC_FAIL_NOT_MATERIALIZED — missing: sdk
    new guard -> passes

drive-cloud.yaml carries the same script as an escaped YAML scalar and needed
the identical change; both files still parse.

This matters beyond the two files: `flows-drive` is how the repo implements
RFC-0001 on itself (§2, "rewrite relayflows using relayflows"). While its
first step fails closed, the dogfooding loop cannot run at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR

Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 34cac1a3-1b29-4594-9270-8c147779f26e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant