Skip to content

style(review-swarm): align the RELAY_WORKSPACE_KEY presence check - #236

Merged
kjgbot merged 1 commit into
mainfrom
fix/rws-indent
Sep 8, 2026
Merged

style(review-swarm): align the RELAY_WORKSPACE_KEY presence check#236
kjgbot merged 1 commit into
mainfrom
fix/rws-indent

Conversation

@kjgbot

@kjgbot kjgbot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Whitespace only, one line.

Resolving the three-way conflict between #226, #232 and #235 by hand, I lifted test -n "$RELAY_WORKSPACE_KEY" out of the branch side and carried the surrounding block's indentation with it, so it sat two spaces deeper than the two presence checks it belongs with.

Shell does not care. A reader does — misaligned indentation arriving from a merge is the first thing that makes someone wonder what else that merge got wrong, and three PRs edited this block in the last hour.

Verified: YAML parses, the step still passes bash -n, and all three test -n lines now share one indent level.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR

Whitespace only. I hand-resolved a conflict between #226, #232 and #235 an hour
ago and carried the surrounding block's indentation onto the line I lifted out
of it, so this check sat two spaces deeper than the two it belongs with. Shell
does not care; a reader does, and misaligned indentation from a merge is the
first thing that makes someone wonder what else the merge got wrong.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6c07e351-4ce2-4dea-bc21-edaa74c539b9


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjgbot
kjgbot merged commit b0046ea into main Sep 8, 2026
2 of 3 checks passed
@kjgbot
kjgbot deleted the fix/rws-indent branch September 8, 2026 06:05
kjgbot pushed a commit that referenced this pull request Sep 8, 2026
… slip

Ran #230's gate against the six merges (2 of 3 checks skip in flows, worth
noting), then bash -n on every run: block since three PRs edited one shell
block. 7/0. Caught and fixed a two-space misalignment from my conflict
resolution in #236.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review swarm: maintainability

No fresh transcript was produced for run 060d3975-ccb1-4f33-813c-0ffc7d8ec6db (MISSING).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review swarm: history

No fresh transcript was produced for run 060d3975-ccb1-4f33-813c-0ffc7d8ec6db (MISSING).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review swarm: structure

No fresh transcript was produced for run 060d3975-ccb1-4f33-813c-0ffc7d8ec6db (MISSING).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review swarm: FAILED

  • maintainability: MISSING
  • history: MISSING
  • structure: MISSING

Cloud run: 060d3975-ccb1-4f33-813c-0ffc7d8ec6db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant