[ITS3] Update default parameters and adapt code to work with fourth layer - #11227
Merged
Conversation
fgrosa
requested review from
arossi81,
iouribelikov,
mconcas and
shahor02
as code owners
April 25, 2023 11:50
fgrosa
added a commit
to fgrosa/AliceO2
that referenced
this pull request
Apr 25, 2023
Please consider the following formatting changes to AliceO2Group#11227
Collaborator
|
Error while checking build/O2/fullCI for d6bada0 at 2023-04-25 14:49: Full log here. |
fgrosa
changed the title
Collaborator
Author
Moved the ITS-related code in #11234 |
Collaborator
|
Error while checking build/O2/fullCI for 56c0ad8 at 2023-04-26 01:42: Full log here. |
fgrosa
marked this pull request as draft
April 26, 2023 15:51
fgrosa
marked this pull request as ready for review
April 27, 2023 09:23
mconcas
approved these changes
Apr 28, 2023
mdiotti
pushed a commit
to mdiotti/AliceO2
that referenced
this pull request
May 25, 2023
…ayer (AliceO2Group#11227) * Change default parameters * Avoid to get GRPECS from CCDB * Fix simulation and digitisation with 4th later * Adapt clusterer to work with 4th layer * Adapt ITS3 tracker to work with 4th layer * Update README * Fix typo * Please consider the following formatting changes * Move modifications to ITS code in dedicated PR * Remove leftover * Fix conflicts * Fix conflicts --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapt the ITS3 code to work with an additional layer. @mconcas @mpuccio I had to make two minor modifications to the
IndexTableUtils.h,TimeFrame.h, andTrackerTraits.hfiles to make it work. They should be harmless, but please have a look that they are fine for you. Thanks a lot!