[EMCAL-834] Checking active links per trigger by mpoghos · Pull Request #11238 · AliceO2Group/AliceO2

mpoghos · 2023-04-26T13:26:48Z

No description provided.

mfasDa

Apart from the global BC using the function from o2::InteractionRecords the rest looks good to me.

mfasDa · 2023-04-26T13:36:30Z

      auto feeID = raw::RDHUtils::getFEEID(header);
      auto triggerbits = raw::RDHUtils::getTriggerType(header);

+      ULong64_t BCcoll = ULong64_t(triggerBC) + ULong64_t(triggerOrbit * 3564);


Please use instead

ULong64_t BCcoll = currentIR.toLong();

instead.

mfasDa · 2023-04-26T13:43:58Z

+  std::unordered_map<ULong64_t, std::bitset<46>>::iterator p;
+  for (p = bcFreq.begin(); p != bcFreq.end(); p++) {
+    if (p->second != bitSetActiveLinks) {


Could be handled with range-based iteration + c++17 structured-binding:

for(const auto &[globalBC, activelinks) : bcFreq) { if (activelinks != bitSetActiveLinks){ ... } }

mfasDa

Looks good!

alibuild · 2023-04-26T17:17:55Z

Error while checking build/O2/fullCI for b20e043 at 2023-04-26 19:17:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[49734:internal-dpl-ccdb-backend]: [17:17:42][ERROR] Exception caught: Fatal error 
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49875 (qc-task-FDD-DigitQcTaskFDD) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49876 (qc-task-FT0-DigitQcTaskFT0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49878 (qc-task-FV0-DigitQcTaskFV0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49909 (qc-task-TRD-Digits) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49913 (qc-task-TRD-Tracklets) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49990 (ZDC-QcZDCRecTask-proxy) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49993 (internal-dpl-injected-dummy-sink) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[49734:internal-dpl-ccdb-backend]: [17:17:42][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch/EMC/Calib/FeeDCS/1550600800000/
[49734:internal-dpl-ccdb-backend]: [17:17:42][FATAL] Unable to find object EMC/Calib/FeeDCS/1550600800000
[49734:internal-dpl-ccdb-backend]: [17:17:42][ERROR] Exception caught: Fatal error 
[49734:internal-dpl-ccdb-backend]: [17:17:42][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] pid 49734 (internal-dpl-ccdb-backend) crashed with or was killed with exit code 1
[ERROR] Workflow crashed - pid 49875 (qc-task-FDD-DigitQcTaskFDD) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49876 (qc-task-FT0-DigitQcTaskFT0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49878 (qc-task-FV0-DigitQcTaskFV0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49909 (qc-task-TRD-Digits) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49913 (qc-task-TRD-Tracklets) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49990 (ZDC-QcZDCRecTask-proxy) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49993 (internal-dpl-injected-dummy-sink) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] websocket_server_callback: Error while reading from websocketconnection reset by peer


## sw/BUILD/o2checkcode-latest/log
--
++ echo '========== List of errors found =========='
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/2f687795929b52afe5b5d9fb8514dc919180e129/slc8_x86-64/o2checkcode/1.0-local88/etc/modulefiles
++ cat
--

Full log here.

alibuild · 2023-04-26T17:18:54Z

Error while checking build/O2/fullCI for 7ae3ac0 at 2023-04-27 13:41:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log-[49381:internal-dpl-ccdb-backend]: [11:41:41][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch/EMC/Calib/FeeDCS/1550600800000/
reco_NOGPU.log-[49381:internal-dpl-ccdb-backend]: [11:41:41][FATAL] Unable to find object EMC/Calib/FeeDCS/1550600800000
reco_NOGPU.log:[49381:internal-dpl-ccdb-backend]: [11:41:41][ERROR] Exception caught: Fatal error 
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49531 (qc-task-FDD-DigitQcTaskFDD) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49534 (qc-task-FT0-DigitQcTaskFT0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49537 (qc-task-FV0-DigitQcTaskFV0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49575 (qc-task-TRD-Digits) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
reco_NOGPU.log:[ERROR] Workflow crashed - pid 49581 (qc-task-TRD-Tracklets) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[49381:internal-dpl-ccdb-backend]: [11:41:41][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch/EMC/Calib/FeeDCS/1550600800000/
[49381:internal-dpl-ccdb-backend]: [11:41:41][FATAL] Unable to find object EMC/Calib/FeeDCS/1550600800000
[49381:internal-dpl-ccdb-backend]: [11:41:41][ERROR] Exception caught: Fatal error 
[49381:internal-dpl-ccdb-backend]: [11:41:41][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] pid 49381 (internal-dpl-ccdb-backend) crashed with or was killed with exit code 1
[ERROR] Workflow crashed - pid 49531 (qc-task-FDD-DigitQcTaskFDD) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49534 (qc-task-FT0-DigitQcTaskFT0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49537 (qc-task-FV0-DigitQcTaskFV0) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49575 (qc-task-TRD-Digits) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] Workflow crashed - pid 49581 (qc-task-TRD-Tracklets) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] websocket_server_callback: Error while reading from websocketconnection reset by peer


## sw/BUILD/o2checkcode-latest/log
--
++ echo '========== List of errors found =========='
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/9d7710cf2472db626af1bcf9fc7e20ee36125c61/slc8_x86-64/o2checkcode/1.0-local89/etc/modulefiles
++ cat
--

Full log here.

mfasDa · 2023-04-26T18:17:22Z

@mpoghos In order to pass the fullCI we need a default CCDB object for EMC/Calib/FeeDCs in the timestamp range of the unanchored MCs.

mfasDa · 2023-04-27T07:29:58Z

Needs https://alice.its.cern.ch/jira/browse/O2-3727

This reverts commit 0a5342b.

* [EMCAL-834] Checking active links per trigger * [EMCAL-834] Checking active links per trigger

…1238)" This reverts commit 0a5342b.

[EMCAL-834] Checking active links per trigger

b20e043

mpoghos requested review from jokonig and mfasDa as code owners April 26, 2023 13:26

mfasDa requested changes Apr 26, 2023

View reviewed changes

[EMCAL-834] Checking active links per trigger

7ae3ac0

mfasDa approved these changes Apr 26, 2023

View reviewed changes

shahor02 merged commit 0a5342b into AliceO2Group:dev Apr 28, 2023

davidrohr added a commit that referenced this pull request May 2, 2023

Revert "[EMCAL-834] Checking active links per trigger (#11238)"

9b70942

This reverts commit 0a5342b.

davidrohr mentioned this pull request May 2, 2023

Revert "[EMCAL-834] Checking active links per trigger" #11266

Merged

davidrohr added a commit that referenced this pull request May 2, 2023

Revert "[EMCAL-834] Checking active links per trigger (#11238)"

25aede2

This reverts commit 0a5342b.

mdiotti pushed a commit to mdiotti/AliceO2 that referenced this pull request May 25, 2023

[EMCAL-834] Checking active links per trigger (AliceO2Group#11238)

9b86853

* [EMCAL-834] Checking active links per trigger * [EMCAL-834] Checking active links per trigger

mdiotti pushed a commit to mdiotti/AliceO2 that referenced this pull request May 25, 2023

Revert "[EMCAL-834] Checking active links per trigger (AliceO2Group#1…

871de38

…1238)" This reverts commit 0a5342b.

Navigation Menu

Uh oh!

[EMCAL-834] Checking active links per trigger - #11238

[EMCAL-834] Checking active links per trigger#11238
shahor02 merged 2 commits into
AliceO2Group:devfrom
mpoghos:CheckDDLs2

mpoghos commented Apr 26, 2023

Uh oh!

mfasDa left a comment

Uh oh!

mfasDa Apr 26, 2023

Uh oh!

mfasDa Apr 26, 2023

Uh oh!

mfasDa left a comment

Uh oh!

alibuild commented Apr 26, 2023

Uh oh!

alibuild commented Apr 26, 2023 •

edited

Loading

Uh oh!

mfasDa commented Apr 26, 2023

Uh oh!

mfasDa commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mpoghos commented Apr 26, 2023

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

mfasDa Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

mfasDa Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented Apr 26, 2023

Uh oh!

alibuild commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfasDa commented Apr 26, 2023

Uh oh!

mfasDa commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

alibuild commented Apr 26, 2023 •

edited

Loading