CPV,PHS: modernize cell, digit and cluster readers

[sevdokim]

Hello! In this PR new digit & cluster reader for cpv and new digit & cell readers for phs are added. This readers needed in MC production for connecting QC. Old readers cannot be used because they produce one more empty TF when finish reading, and this empty TF crashes QC.

[sevdokim]

Hi @shahor02
I got fails of trivial checks with error
fatal: couldn't find remote ref pull/12060/head
What can it be?

[shahor02]

pinging to @TimoWilken

[sevdokim]

Force-pushing triggered checks again. This time they were successful.

[alibuild]

Error while checking build/O2/fullCI for c7bbbf2 at 2023-10-14 00:23:

No log files found

Full log here.

[shahor02]

Thanks, could you also use new readers here:

AliceO2/Detectors/GlobalTrackingWorkflow/helpers/src/InputHelper.cxx

Lines 166 to 172 in 500326b

	if (maskTracks[GID::PHS] || maskClusters[GID::PHS]) {
	specs.emplace_back(o2::phos::getCellReaderSpec(maskTracksMC[GID::PHS] || maskClustersMC[GID::PHS]));
	}
	if (maskTracks[GID::CPV] || maskClusters[GID::CPV]) {
	specs.emplace_back(o2::cpv::getClustersReaderSpec(maskTracksMC[GID::CPV] || maskClustersMC[GID::CPV]));
	}

[sevdokim]

hi @shahor02
yes, of cause. Can you please tell me how to check that GlobalTrackingWorkflow works as expected after changing readers?

[shahor02]

Global tracking workflow is just a collection of workflows. The InputHelper allows to start set of readers on demand. So, if your previous reader workflows were doing an extra run cycle, just substitute relevant old getXXXreaderSpec by that of the new readers.

[sevdokim]

Hi @shahor02
thanks. I putted new readers to InputHelper.cxx
Checks are passed except masOS build but I think it is not relevant.