quick fix for uint32_t ITSClusterSizes in AnalysisDataModel.h - #12186
Merged
Conversation
jgrosseo
approved these changes
Nov 1, 2023
Collaborator
|
|
ktf
enabled auto-merge (rebase)
November 1, 2023 07:46
ktf
self-requested a review
November 1, 2023 07:51
ktf
approved these changes
Nov 1, 2023
Member
|
Indeed I cannot find any reason why this should not merge. I even did my approval. @TimoWilken did anything change on the approval side recently? |
shahor02
disabled auto-merge
November 1, 2023 08:12
shahor02
enabled auto-merge (squash)
November 1, 2023 08:13
TimoWilken
disabled auto-merge
November 1, 2023 09:33
TimoWilken
enabled auto-merge (squash)
November 1, 2023 09:34
TimoWilken
disabled auto-merge
November 1, 2023 09:34
Contributor
|
Hi @jgrosseo, @ktf, I think I made a mistake moving from "branch protection rules" to "branch rulesets". The "Restrict updates" option was enabled under the old system, but I should not have enabled it under the new system. Disabled now, it seems to work -- the "merging is blocked" message disappeared and I could merge this without admin permissions. Let me know if you see this problem again! |
Collaborator
|
Thanks! |
christianreckziegel
pushed a commit
to LucasFerrandi/AliceO2
that referenced
this pull request
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick fix for uint32_t ITSClusterSizes in AnalysisDataModel.h