Skip to content

TPC: improving simulation of distortions in MC - #13345

Merged
wiechula merged 2 commits into
AliceO2Group:devfrom
matthias-kleiner:spacechargedev
Aug 8, 2024
Merged

TPC: improving simulation of distortions in MC#13345
wiechula merged 2 commits into
AliceO2Group:devfrom
matthias-kleiner:spacechargedev

Conversation

@matthias-kleiner

@matthias-kleiner matthias-kleiner commented Aug 1, 2024

Copy link
Copy Markdown
Contributor
  • adding option to recalculate (merging) the distortions in case of large scaling
  • accessing the distortions of the derivative map at the distorted position for better consistency with corrections
  • optimizing default parameters for calculating distortions/corrections

@github-actions

github-actions Bot commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild alibuild mentioned this pull request Aug 1, 2024
Closed
@matthias-kleiner
TPC: improving simulation of distortions in MC
39b66da 
- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections
wiechula
wiechula requested changes Aug 7, 2024
View reviewed changes
Comment thread Detectors/TPC/simulation/src/Digitizer.cxx Outdated
Comment thread Detectors/TPC/spacecharge/src/SpaceCharge.cxx Outdated
@wiechula

wiechula commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator

+async-label async-2023-pbpb-apass4

@github-actions github-actions Bot added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Aug 7, 2024
@matthias-kleiner

matthias-kleiner commented Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the comments @wiechula . I changed the code accordingly

@alibuild

alibuild commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 39b66da at 2024-08-07 18:45:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-sim-challenge-test-latest/log
./tofMatchTracks.log[ERROR] Workflow crashed - PID 21002 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./tofMatchTracks.log[ERROR]  - Device tof-matcher: pid 21002 (exit 128)
./tofMatchTracks.log[ERROR] SEVERE: Device tof-matcher (21002) returned with 128
./mchreco.log[13749:mch-error-writer]: [16:43:48][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./mchreco.log[13750:mch-track-writer]: [16:43:48][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./sim-challenge.log[ERROR] Workflow crashed - PID 21002 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device tof-matcher: pid 21002 (exit 128)
./sim-challenge.log[ERROR] SEVERE: Device tof-matcher (21002) returned with 128
./midreco.log[15669:MIDRecoWriter]: [16:44:17][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./mchmidMatch.log[16489:muon-track-writer]: [16:44:25][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7390:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7388:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7393:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7393:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7393:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
[0 more errors; see full log]

Full log here.

wiechula
wiechula approved these changes Aug 8, 2024
View reviewed changes

@wiechula wiechula left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthias-kleiner !

@wiechula
wiechula enabled auto-merge (squash) August 8, 2024 07:54
@wiechula

wiechula commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

@shahor02 , can you please check and approve.

@wiechula
wiechula merged commit 91dd4df into AliceO2Group:dev Aug 8, 2024
chiarazampolli pushed a commit that referenced this pull request Aug 26, 2024
@matthias-kleiner @chiarazampolli
TPC: improving simulation of distortions in MC (#13345)
b6a7ad3 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
@chiarazampolli chiarazampolli removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Aug 26, 2024
@chiarazampolli

chiarazampolli commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

Label removed, PR is in async-v1-01-16.

@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 31, 2025
alcaliva pushed a commit that referenced this pull request Jan 31, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
bb1d438 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
alcaliva pushed a commit that referenced this pull request Jan 31, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
d9895b7 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
alcaliva pushed a commit that referenced this pull request Jan 31, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
251ece0 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
alcaliva pushed a commit that referenced this pull request Feb 2, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
6cb0a85 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
alcaliva pushed a commit that referenced this pull request Feb 2, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
c9359e6 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
alcaliva pushed a commit that referenced this pull request Feb 2, 2025
@matthias-kleiner @alcaliva
TPC: improving simulation of distortions in MC (#13345)
9e69b33 
* TPC: improving simulation of distortions in MC

- adding option to recalculate (merging) the distortions in case of large scaling
- accessing the distortions of the derivative map at the distorted
position for better consistency with corrections

* TPC: Renaming variables

(cherry picked from commit 91dd4df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes
@wiechula wiechula wiechula approved these changes
@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner
@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel
@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

Assignees

No one assigned

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthias-kleiner @wiechula @alibuild @chiarazampolli @shahor02 @alcaliva