Make it explicit we are currently using a signed char - #13375
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
@davidrohr this fixes one of the two tests on ARM. |
davidrohr
left a comment
There was a problem hiding this comment.
makes sense, but the error during the RTC test is genuine :(.
In a few places the code checks for the value being positive, which of course is always true in case char is unsigned.
|
Added the specialization for the printout. |
|
Error while checking build/O2/fullCI for c731b2a at 2024-08-13 16:18: Full log here. |
|
Verified to fix one of the two ARM tests. |
On x86 Linux
charis assumed to be signed, however that's an implementation detail.This makes sure we are explicit about the sign-ness.