ITS-GPU: Update the Hybrid interface

[mconcas]

to the latest devs

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

[alibuild]

Error while checking build/O2/fullCI for f7d4bb4 at 2024-08-14 12:55:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Global/GPUChainITS.cxx:40:14: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/BUILD/7eba8e02fc26d8cf819e2beec23b8dfbb18a9b4c/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/VertexerTraitsGPU.hip:94:20: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

[alibuild]

Error while checking build/O2/fullCI for 0e6e827 at 2024-08-17 11:40:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Global/GPUChainITS.cxx:40:14: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

[mconcas]

Error while checking build/O2/fullCI for 0e6e827 at 2024-08-14 19:46:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Global/GPUChainITS.cxx:40:14: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@ktf this is the issue I was referring to: llvm/llvm-project#92250

The feeling is that either after the thinning of the compile_commands.json or in general also with the full compile_commands.json, clang-tidy does not find the std headers somehow and then fails on something like:

Error while processing /sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Global/GPUChainITS.cxx.
/sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Base/GPUReconstruction.h:18:10: error: 'cstddef' file not found [clang-diagnostic-error]
   18 | #include <cstddef>
      |          ^~~~~~~~~

then degenerates in:

/sw/SOURCES/O2/13383-slc8_x86-64/0/GPU/GPUTracking/Global/GPUChainITS.cxx:40:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
   40 | GPUChainITS::~GPUChainITS()

could it be related to the bumping of clang, @davidrohr ?

[davidrohr]

No idea, but I also saw bogus clang tidy warnings recently.
I think it appeared after bumping llvm. Though, I tried the codechecker with the bumped LLVM once in the build container before merging, and there I didn't get the error.

[mconcas]

No idea, but I also saw bogus clang tidy warnings recently. I think it appeared after bumping llvm. Though, I tried the codechecker with the bumped LLVM once in the build container before merging, and there I didn't get the error.

It happens to changed files and their dependencies. Maybe you were lucky and did not change an affected file.

Like, in this case: the thinning command is:

ThinCompilationsDatabase.py -exclude-files '(?:.*G\_\_.*\.cxx|.*\.pb.cc|.*\_amalgamated\..*)' -use-files Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/VertexerTraitsGPU.h:Detectors/ITSMFT/ITS/tracking/include/ITStracking/Vertexer.h:Detectors/ITSMFT/ITS/tracking/include/ITStracking/VertexerTraits.h:Detectors/ITSMFT/ITS/tracking/src/Vertexer.cxx

then the clang-tidy is run only on a subset of the commands. Maybe in your case everything was just excluded.

[davidrohr]

No, I compiled O2 from scratch to make sure it ran over all files, and I checked that it did.

[davidrohr]

Perhaps this is also related to the fixing of GCC header path in clang, which breaks the relocation @ktf ?

[davidrohr]

Perhaps we need ${GCC_TOOLCHAIN_REVISION:+-DGCC_TOOLCHAIN_ROOT=$GCC_TOOLCHAIN_ROOT} for the codechecker as well, as in https://github.com/alisw/alidist/pull/5579/files

[chiarazampolli]

Label async-2023-pbpb-apass4 added to allow commit 7a6665b (needed for the same label) to apply.

[chiarazampolli]

Label removed, PR is in async-v1-01-16.