Skip to content

DPL Analysis: avoid base_of_template in concepts for column type identification - #13889

Merged
ktf merged 2 commits into
AliceO2Group:devfrom
aalkin:improve-concepts
Jan 23, 2025
Merged

DPL Analysis: avoid base_of_template in concepts for column type identification#13889
ktf merged 2 commits into
AliceO2Group:devfrom
aalkin:improve-concepts

Conversation

@aalkin

@aalkin aalkin commented Jan 22, 2025

Copy link
Copy Markdown
Member

No description provided.

@aalkin
aalkin requested a review from a team as a code owner January 22, 2025 10:31
@aalkin
aalkin requested a review from ktf January 22, 2025 10:32
@github-actions

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf

ktf commented Jan 22, 2025

Copy link
Copy Markdown
Member

Very nice. I assume you have another one coming up which actually drops the associated select_pack as discussed yesterday?

@aalkin

aalkin commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

Yes, I'm now checking if I can remove even more of the stuff in one go, not just the obsolete traits and pack selections.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 1802225 at 2025-01-22 19:15:

## sw/BUILD/ONNXRuntime-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.28.1-13/share/cmake-3.28/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):

Full log here.

@ktf
ktf merged commit 5efb6e2 into AliceO2Group:dev Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants