Changes in TPC residuals validation#15524
Open
shahor02 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@matthias-kleiner : the default behaviour did not change, to have in the unbinned residuals the tracks not passing validation (flagged as described in the commit description) use |
Contributor
Many thanks for the option to write out all data! |
The meaning of the scdcalib.writeUnfiltered (default: false) ConfigurableParam has changed. If set to true, tracks that do not pass the validateTrack check will no longer be discarded but will instead be stored in the standard unbinned residuals data. The int8_t TrackData::filterFlag field provides the status of the validation check: -1: no validation check was requested; 0: validation passed; >0: reason for failing validation (see the validateTrack method). A new ConfigurableParam, scdcalib.writeValidationData (default: false), has been added. If set to true, the TrackValidationData object, together with the corresponding TrackData, will be written to a dedicated debug tree, "valdata", in "track_interpolation_dbg.root" (or "track_interpolation_dbg_<lane>.root" when multiple lanes are used). If a track passes validation but some residuals are flagged as bad, the new ConfigurableParam scdcalib.keepRejectedResiduals (default: false) allows these residuals to be written to the unbinned residuals tree with the bool UnbinnedResid::rejected flag set (previously, such residuals were discarded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meaning of the scdcalib.writeUnfiltered (default: false) ConfigurableParam has changed. If set to true, tracks that do not pass the validateTrack check will no longer be discarded but will instead be stored in the standard unbinned residuals data. The int8_t TrackData::filterFlag field provides the status of the validation check: -1: no validation check was requested; 0: validation passed; >0: reason for failing validation (see the validateTrack method).
A new ConfigurableParam, scdcalib.writeValidationData (default: false), has been added. If set to true, the TrackValidationData object, together with the corresponding TrackData, will be written to a dedicated debug tree, "valdata", in "track_interpolation_dbg.root" (or "track_interpolation_dbg_.root" when multiple lanes are used).
If a track passes validation but some residuals are flagged as bad, the new ConfigurableParam scdcalib.keepRejectedResiduals (default: false) allows these residuals to be written to the unbinned residuals tree with the bool UnbinnedResid::rejected flag set (previously, such residuals were discarded).