Skip to content

GPU: provide the std type_traits subset used on Metal #15794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Sep 16, 2026
+24 −12
Merged

GPU: provide the std type_traits subset used on Metal #15794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d5321
GPU: fix typo
ktf Sep 15, 2026
0663dd6
GPU: provide the std type_traits subset used on Metal
ktf Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GPU/Common/GPUCommonDef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include "GPUCommonDefSettings.h"

#if !defined(__CLING__) && !defined(G__ROOT) // No GPU code for ROOT
#if defined(__CUDACC__) || defined(__OPENCL__) || defined(__HIPCC__) || defined(__OPENCL_HOST__) || defined(__METAL_HOST__)
#if defined(__CUDACC__) || defined(__OPENCL__) || defined(__HIPCC__) || defined(__OPENCL_HOST__) || defined(__METAL__) || defined(__METAL_HOST__)
#define GPUCA_GPUCODE // Compiled by GPU compiler
#endif

Expand Down
34 changes: 23 additions & 11 deletions GPU/Common/GPUCommonTypeTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,16 @@
#ifndef GPUCA_GPUCODE_COMPILEKERNELS
#include <type_traits>
#endif
#else // OpenCL C++ and Metal, neither of which provides <type_traits>
// Spelled for MSL, which OpenCL C++ also accepts, so both backends share one implementation:
// enum values because program scope variables must be constant (MSL 4.1 spec, sec. 4.2), and
// is_pointer / is_member_pointer forward rather than inherit because MSL has no derived classes
// (sec. 1.5.4). Bare T* / T& need no address space: a partial specialization matches them all.
#ifdef __METAL__
#define GPUCA_TT_PROGRAMSCOPE constant
#else
#define GPUCA_TT_PROGRAMSCOPE // not empty-by-default: in OpenCL 'constant' would mean __constant
#endif
namespace std
{
template <bool B, class T, class F>
Expand All @@ -33,18 +42,18 @@ struct conditional<false, T, F> {
typedef F type;
};
template <bool B, class T, class F>
using contitional_t = typename conditional<B, T, F>::type;
using conditional_t = typename conditional<B, T, F>::type;

template <class T, class U>
struct is_same {
static constexpr bool value = false;
enum { value = false };
};
template <class T>
struct is_same<T, T> {
static constexpr bool value = true;
enum { value = true };
};
template <class T, class U>
static constexpr bool is_same_v = is_same<T, U>::value;
GPUCA_TT_PROGRAMSCOPE static constexpr bool is_same_v = is_same<T, U>::value;

template <bool B, class T = void>
struct enable_if {
Expand Down Expand Up @@ -97,14 +106,15 @@ using remove_volatile_t = typename remove_volatile<T>::type;

template <class T>
struct is_pointer_t {
static constexpr bool value = false;
enum { value = false };
};
template <class T>
struct is_pointer_t<T*> {
static constexpr bool value = true;
enum { value = true };
};
template <class T>
struct is_pointer : is_pointer_t<typename std::remove_cv<T>::type> {
struct is_pointer {
enum { value = is_pointer_t<typename std::remove_cv<T>::type>::value };
};

template <class T>
Expand All @@ -124,19 +134,21 @@ using remove_reference_t = typename remove_reference<T>::type;

template <class T>
struct is_member_pointer_helper {
static constexpr bool value = false;
enum { value = false };
};
template <class T, class U>
struct is_member_pointer_helper<T U::*> {
static constexpr bool value = true;
enum { value = true };
};
template <class T>
struct is_member_pointer : is_member_pointer_helper<typename std::remove_cv<T>::type> {
struct is_member_pointer {
enum { value = is_member_pointer_helper<typename std::remove_cv<T>::type>::value };
};
template <class T>
static constexpr bool is_member_pointer_v = is_member_pointer<T>::value;
GPUCA_TT_PROGRAMSCOPE static constexpr bool is_member_pointer_v = is_member_pointer<T>::value;

} // namespace std
#undef GPUCA_TT_PROGRAMSCOPE
#endif

#endif
Loading