TRD: Benefit from custom streamer for labels - #3068
Merged
Merged
Conversation
Collaborator
Author
|
@shahor02 : This fixes the problem with TRD in the sim challenge. |
* use standard MCCompLabel for TRD * generalize MCCompLabel constructor * benefit from custom streamer for MCTruthContainer for TRD fixed https://alice.its.cern.ch/jira/browse/O2-1213
sawenzel
force-pushed
the
swenzel/trdlabelfix
branch
from
March 3, 2020 15:45
a9c1e9b to
fe340d8
Compare
jolopezl
reviewed
Mar 3, 2020
| ClassDefNV(MCLabel, 1); | ||
| }; | ||
|
|
||
| using MCLabel = o2::MCCompLabel; |
Contributor
There was a problem hiding this comment.
With this change, I am wondering if we really need to keep o2::trd::MCLabel. I would suggest removing it, unless we want to keep it for future specializations. It is more direct and easier to maintain if we just o2::MCCompLabel as this is suggesting.
Collaborator
Author
|
@jolopezl : Merged it like this since it fixes a bug. I invite you to clean up further and remove that class/file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed https://alice.its.cern.ch/jira/browse/O2-1213