DPL Analysis: allow std::vector column types backed by variable size list - #7021
Merged
Conversation
…list * Update TableBuilder to handle writing vectors * Update ColumnIterator to handle extracting vectors * Add a test case to test_ASoA
Member
Author
|
C++20 |
Member
Author
|
Now list column getter will return a |
Member
|
As discussed we should probably use the filler with the iterator pairs, so that one does not need a std::vector on filling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ktf this works, but I have doubts about using std::vector here (although very convenient)