Skip to content

Implement CTP CTF and add CTP to FST#7121

Merged
shahor02 merged 4 commits into
AliceO2Group:devfrom
shahor02:pr_ctpCTF
Sep 27, 2021
Merged

Implement CTP CTF and add CTP to FST#7121
shahor02 merged 4 commits into
AliceO2Group:devfrom
shahor02:pr_ctpCTF

Conversation

@shahor02

Copy link
Copy Markdown
Collaborator

Hi @lietava

CTP decoding was producing more logs than all other detectors together, so I've changed a lot of INFOs to DEBUG in your code.
Also, had to touch your digits class.

The CTP digit2row still has this custom option --file-per-link instead of --file-for [all,link,cru], could you please fix this? The output naming is ok.

Then, your raw->digits decoder is for some reason named o2-ctp-reco-workflow, Could you please rename it to something more appropriate, e.g. o2-ctp-raw-decoder. More serious is that it declares a lot of options which it is not supposed to support, I guess it comes from some copy/paste.

  --input-type arg (=raw)               digits, raw
  --output-type arg (=digits)           digits, raw
  --disable-mc                          disable sending of MC information
  --disable-root-input                  disable root-files input reader
  --disable-root-output                 disable root-files output writer

Can you have input other than raw and output other than digits?
Raw decoders are not supposed to support MC, so you don't need this option at all.
And for the raw decoders there is no root input anyway.

@shahor02 shahor02 requested a review from a team as a code owner September 24, 2021 22:04
@lietava

lietava commented Sep 26, 2021

Copy link
Copy Markdown
Contributor

Hi @shahor02 , thanks. I'll fix it latest after apw

@shahor02 shahor02 merged commit e57ba68 into AliceO2Group:dev Sep 27, 2021
@shahor02 shahor02 deleted the pr_ctpCTF branch September 27, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants