Implement CTP CTF and add CTP to FST#7121
Merged
Merged
Conversation
Contributor
|
Hi @shahor02 , thanks. I'll fix it latest after apw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lietava
CTP decoding was producing more logs than all other detectors together, so I've changed a lot of INFOs to DEBUG in your code.
Also, had to touch your digits class.
The CTP digit2row still has this custom option
--file-per-linkinstead of--file-for [all,link,cru], could you please fix this? The output naming is ok.Then, your raw->digits decoder is for some reason named
o2-ctp-reco-workflow, Could you please rename it to something more appropriate, e.g.o2-ctp-raw-decoder. More serious is that it declares a lot of options which it is not supposed to support, I guess it comes from some copy/paste.Can you have input other than raw and output other than digits?
Raw decoders are not supposed to support MC, so you don't need this option at all.
And for the raw decoders there is no root input anyway.