Skip to content

FIT: add time-calibration command line option#7416

Merged
shahor02 merged 3 commits into
AliceO2Group:devfrom
phymanshu:O2hsharma
Nov 4, 2021
Merged

FIT: add time-calibration command line option#7416
shahor02 merged 3 commits into
AliceO2Group:devfrom
phymanshu:O2hsharma

Conversation

@phymanshu

Copy link
Copy Markdown
Contributor

No description provided.

@AllaMaevskaya AllaMaevskaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but I can not imagine case when we need to calibrate data outside 2.5 ns (200 channels) range. It could be special artificial laser runs. I prefer to keep narrow range to remove tails and signals from slow particles

jotwinow
jotwinow previously approved these changes Oct 25, 2021
@phymanshu

Copy link
Copy Markdown
Contributor Author

Hi @shahor02
Builds were failed but the errors are not related to the developments. Could you please check?

@shahor02

Copy link
Copy Markdown
Collaborator

@HimanshuCERN those which failed are unrelated, let's wait for others to converge.

AllaMaevskaya
AllaMaevskaya previously approved these changes Oct 27, 2021
@phymanshu

Copy link
Copy Markdown
Contributor Author

Hi @shahor02
Are there any problems in this PR.?

@AllaMaevskaya AllaMaevskaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change
int FT0ChannelTimeTimeSlotContainer::sGausFitBins = 999;
to 100?
Results of fitting in so wide interval are wrong, I checked

@phymanshu

Copy link
Copy Markdown
Contributor Author

Hi
@AllaMaevskaya @jotwinow
I added the same fitting option for FT0Calibration-Workflow.cxx and committed in the same branch.
Alla you can check it now from this branch and run o2-calibration-ft0-calibration workflow...

@alibuild

alibuild commented Nov 2, 2021

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for e81aebf at 2021-11-03 00:12:

sw/BUILD/O2DPG-latest/log
++ rsync -a '--exclude=**/.git' --delete --delete-excluded /sw/SOURCES/O2DPG/master/daa2e0add3/ /sw/INSTALLROOT/7d2a346391c70dd4e57039bf2f5bb8a6b8ea9c1a/slc8_x86-64/O2DPG/master-local1/
++ mkdir -p /sw/INSTALLROOT/7d2a346391c70dd4e57039bf2f5bb8a6b8ea9c1a/slc8_x86-64/O2DPG/master-local1/etc/modulefiles
++ alibuild-generate-module
DEFAULTS_RELEASE is a build_requires. Skipping loading the associated module.
++ cat
sw/BUILD/Control-Core-latest/log
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading golang.org/x/term v0.0.0-20201210144234-2321bbc49cbf
go: downloading github.com/mwitkow/go-proto-validators v0.0.0-20180403085117-0950a7990007
go: downloading github.com/coreos/go-semver v0.3.0
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
go: downloading cloud.google.com/go/firestore v1.4.0
go: downloading github.com/hashicorp/go-hclog v0.15.0
go: downloading github.com/json-iterator/go v1.1.10
go: downloading github.com/valyala/bytebufferpool v1.0.0
go: downloading gopkg.in/warnings.v0 v0.1.2
go: downloading github.com/jstemmer/go-junit-report v0.9.1
go: downloading google.golang.org/appengine v1.6.7
go: downloading go.opencensus.io v0.22.6
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading github.com/hashicorp/go-rootcerts v1.0.2
go: downloading github.com/envoyproxy/protoc-gen-validate v0.4.1
go: downloading github.com/armon/go-metrics v0.3.6
go: downloading golang.org/x/mod v0.4.2
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/osamingo/indigo v1.1.0
go: downloading github.com/hashicorp/go-immutable-radix v1.3.0
go: downloading github.com/Masterminds/sprig v2.22.0+incompatible
go: downloading github.com/osamingo/base58 v1.0.0
go: downloading github.com/sony/sonyflake v1.0.1-0.20200827011719-848d664ceea4
go: downloading github.com/hashicorp/golang-lru v0.5.4
go: downloading github.com/huandu/xstrings v1.3.2
go: downloading github.com/mitchellh/copystructure v1.1.1
go: downloading github.com/Masterminds/goutils v1.1.1
go: downloading github.com/mitchellh/reflectwalk v1.0.1
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/google/go-cmp v0.5.4
�[1;33mcurl odc.proto�[0m
�[1;33mcurl ddsched.proto�[0m
�[1;33mpatch odc.proto�[0m
++ make 'WHAT=o2-aliecs-core o2-aliecs-executor o2-apricot'
�[1;33mgo build -mod=vendor�[0m ./cmd/o2-aliecs-core  �[1;33m==>�[0m  �[1;34m./bin/o2-aliecs-core�[0m
�[1;33mgo build -mod=vendor�[0m ./cmd/o2-aliecs-executor  �[1;33m==>�[0m  �[1;34m./bin/o2-aliecs-executor�[0m
�[1;33mcopy�[0m ./cmd/o2-aliecs-shmcleaner  �[1;33m==>�[0m  �[1;34m./bin/o2-aliecs-shmcleaner�[0m
�[1;33mgo build -mod=vendor�[0m ./cmd/o2-apricot  �[1;33m==>�[0m  �[1;34m./bin/o2-apricot�[0m
++ mkdir -p /sw/INSTALLROOT/c4c1172e0814d272de4ccd22ba4cc1ea8de8a6f8/slc8_x86-64/Control-Core/v0.28.0-local1/bin
++ rsync -a --delete bin/ /sw/INSTALLROOT/c4c1172e0814d272de4ccd22ba4cc1ea8de8a6f8/slc8_x86-64/Control-Core/v0.28.0-local1/bin

Full log here.

@phymanshu

phymanshu commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

@jotwinow
The error seems to be from the CCDB. I build the s/w locally twice but there is no error. Also you can see here
the problem also arises with TRD... (Thanks @sbysiak for pointing this out)
@AllaMaevskaya maybe you can try to run/test changes from this repo and merge it...
Thanks a lot!!!

@AllaMaevskaya

Copy link
Copy Markdown
Contributor

I merged this branch with recent dev and it passed all tests

@shahor02 shahor02 merged commit 69fd283 into AliceO2Group:dev Nov 4, 2021
ezradlesser pushed a commit to ezradlesser/AliceO2 that referenced this pull request Dec 2, 2021
FIT: add time-calibration command line option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants