Add metadata to AOD#7503
Conversation
…d-metadata � Conflicts: � Detectors/AOD/include/AODProducerWorkflow/AODProducerWorkflowSpec.h � Detectors/AOD/src/AODProducerWorkflowSpec.cxx
| converterVersion += o2::fullVersion(); | ||
| converterVersion += " ; root "; | ||
| converterVersion += ROOT_RELEASE; | ||
| mMetaData.Add(new TObjString("Run3ConverterVersion"), new TObjString(converterVersion)); |
There was a problem hiding this comment.
You can rename this to "O2Version" and just put o2::fullVersion there, then let's make an additional one "ROOTVersion" for ROOT_RELEASE
| TString mLPMProdTag{"LHC21Axx"}; | ||
| TString mAnchorPass{"pass1"}; | ||
| TString mAnchorProd{"LHC15o"}; | ||
| TString mRecoPass{"pass1"}; |
There was a problem hiding this comment.
Please put empty defaults. We should not have meaningful defaults (like it was for the run number), this causes trouble often. ;)
| LOGF(info, "Metadata: writing into %s", mResFile); | ||
| fResFile->WriteObject(&mMetaData, "metaData"); | ||
| } else { | ||
| LOGF(info, "Metadata: target file not found or metadata is already written"); |
There was a problem hiding this comment.
I think this is not the case of file not found. It is just the if (!fResFile->FindObjectAny("metaData"))
Are there valid cases when this is allowed? Otherwise it should be fatal
I think it should also be fatal if the output file is not found
| ConfigParamSpec{"lpmp-prod-tag", VariantType::String, "LHC21Axx", {"LPMProductionTag"}}, | ||
| ConfigParamSpec{"anchor-pass", VariantType::String, "pass1", {"AnchorPassName"}}, | ||
| ConfigParamSpec{"anchor-prod", VariantType::String, "LHC15o", {"AnchorProduction"}}, | ||
| ConfigParamSpec{"reco-pass", VariantType::String, "LHC15o", {"RecoPassName"}}, |
|
Hi @jgrosseo. Thank you for taking a look at the code. I have fixed it according to your comments |
|
@nburmaso : Can we remove the draft status to trigger the CI? |
|
@sawenzel, yes sure. Also, notice that TMap is written separately from tables, and some O2DPG scripts may need tuning because of it (e.g. due to files merging) |
|
@nburmaso : Could you suggest necessary changes in O2DPG yourself? It's not clear to me what needs to be done. |
|
@sawenzel: I'm not sure myself if changes are even needed, it's only my guess. Sorry if it was too bothersome :) |
|
The merger already deals with the meta data correctly. |
* Add metadata to AOD * pass production tags using separate configurables * set data type
3 participants
@jgrosseo, @sawenzel: This is a fixed PR, following #7501