Skip to content

Revert "DPL raw proxy: Supporting message sequences/pruned headers"#7927

Merged
ktf merged 3 commits into
devfrom
revert-7914-dev-ExternalFairMQDeviceProxy
Jan 11, 2022
Merged

Revert "DPL raw proxy: Supporting message sequences/pruned headers"#7927
ktf merged 3 commits into
devfrom
revert-7914-dev-ExternalFairMQDeviceProxy

Conversation

@davidrohr

@davidrohr davidrohr commented Jan 11, 2022

Copy link
Copy Markdown
Collaborator

Reverts #7914

This breaks the processing on the EPN. The raw-proxy segfaults with this PR. If I revert this PR the segfault is gone.

I can reproduce this in the full system test starting from DataDistribution.
It is not seen in the FullCI, since the FullCI does not use DataDistribution, but it starts from the raw reader.

Will merge when CI through, since currently broken.

In order to reproduce:
You can use my DD FST dataset on the EPNs:

cd /home/drohr/alitest/tmp-fst10
TFDELAY=5 NTIMEFRAMES=8 $O2_ROOT/prodtests/full-system-test/start_tmux.sh dd

Or alternatively generating a DD FST dataset is describer here, for reference: https://alice.its.cern.ch/jira/browse/O2-1492
Then please use the same start_tmux.sh dd command to reproduce.

@davidrohr davidrohr requested a review from a team as a code owner January 11, 2022 09:15
@ktf

ktf commented Jan 11, 2022

Copy link
Copy Markdown
Member

@sawenzel there seems to be a genuine (unrelated to this PR) issue in simulation?

/sw/SOURCES/O2/7927-slc8_x86-64/0/Detectors/MUON/MID/Simulation/test/testSimulation.cxx(464): �[1;31;49merror: in "o2_mid_simulation/MID_SimClusters/_5": check sortedPC.size() == 1 has failed [0 != 1]
Failure occurred in a following context:
    deId = 20; �[0;39;49m
/sw/SOURCES/O2/7927-slc8_x86-64/0/Detectors/MUON/MID/Simulation/test/testSimulation.cxx(466): �[1;31;49merror: in "o2_mid_simulation/MID_SimClusters/_5": (
Failure occurred in a following context:
    deId = 20; �[0;39;49m

@ktf

ktf commented Jan 11, 2022

Copy link
Copy Markdown
Member

@matthiasrichter are you ok with the revert or you know what is wrong and can do an hotfix?

@davidrohr

Copy link
Copy Markdown
Collaborator Author

@matthiasrichter are you ok with the revert or you know what is wrong and can do an hotfix?

ok, but I would like to have a working build for the EPNs tomorrow.
So we can wait a bit but if it is not fixed by tonight, I'll revert it.

@ktf

ktf commented Jan 11, 2022

Copy link
Copy Markdown
Member

Yes, agreed. Since it's 3 commits it is always a pain when we revert so if we can avoid it, it would be better. It also breaks QC (@knopers8 @Barthelemy) although it happens sporadically there.

@matthiasrichter

Copy link
Copy Markdown
Collaborator

@davidrohr I'm on it, but just merge to get the build up and running.

@ktf

ktf commented Jan 11, 2022

Copy link
Copy Markdown
Member

@TimoWilken the build here is ongoing since 11:00 (now 17).

@ktf ktf merged commit aa64ad5 into dev Jan 11, 2022
@ktf

ktf commented Jan 11, 2022

Copy link
Copy Markdown
Member

Verified by David for full CI. Merging since it's broken in any case.

@TimoWilken

Copy link
Copy Markdown
Contributor

About the lagging CI: there was an issue on some of the hosts with installing PyGithub (as they don't have a C compiler on the host). Using PyGithub 1.54.1 (instead of the current 1.55) worked as a temporary workaround.

@TimoWilken TimoWilken deleted the revert-7914-dev-ExternalFairMQDeviceProxy branch April 13, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants