Skip to content

DPL Analysis: add exception for unsorted unassigned groups #7998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgrosseo merged 3 commits into from
Jan 25, 2022
Merged

DPL Analysis: add exception for unsorted unassigned groups #7998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41fb595
DPL Analysis: add exception for unsorted unassigned groups
aalkin Jan 24, 2022
1cc7532
improve the logic to handle groups split by opposite-signed index
aalkin Jan 24, 2022
e86009d
fixup! improve the logic to handle groups split by opposite-signed index
aalkin Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions Framework/Core/include/Framework/Kernels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,30 @@ auto sliceByColumn(
for (auto i = 0; i < column->num_chunks(); ++i) {
T prev = 0;
T cur = 0;
T lastNeg = 0;
T lastPos = 0;

auto array = static_cast<arrow::NumericArray<typename detail::ConversionTraits<T>::ArrowType>>(column->chunk(i)->data());
for (auto e = 0; e < array.length(); ++e) {
if (cur >= 0) {
prev = cur;
prev = cur;
if (prev >= 0) {
lastPos = prev;
} else {
lastNeg = prev;
}
cur = array.Value(e);
if (cur >= 0 && prev > cur) {
throw runtime_error_f("Table %s index %s is not sorted: next value %d < previous value %d!", target, key, cur, prev);
if (cur >= 0) {
if (lastPos > cur) {
throw runtime_error_f("Table %s index %s is not sorted: next value %d < previous value %d!", target, key, cur, lastPos);
} else if (lastPos == cur && prev < 0) {
throw runtime_error_f("Table %s index %s has a group with index %d that is split by %d", target, key, cur, prev);
}
} else {
if (lastNeg < cur) {
throw runtime_error_f("Table %s index %s is not sorted: next negative value %d > previous negative value %d!", target, key, cur, lastNeg);
} else if (lastNeg == cur && prev >= 0) {
throw runtime_error_f("Table %s index %s has a group with index %d that is split by %d", target, key, cur, prev);
}
}
}
}
Expand Down