MCH: improve raw decoder diagnostics by aferrero2707 · Pull Request #9881 · AliceO2Group/AliceO2

aferrero2707 · 2022-09-21T08:07:49Z

The following decoding errors can now be detected and reported:

badly formatted SYNC words
SAMPA packet headers consistency
- chip address and e-link index compatibility
- num of 10-bit words multiple of 4 in cluster sum mode

The check of the digits time in DataDecoder has also been removed, because the corresponding "Bad digit time" error type has been removed as well. The digit time can be checked offline with digit.getTime() != DataDecoder::tfTimeInvalid.

alibuild · 2022-09-21T08:51:03Z

Error while checking build/O2/o2-cs8 for becc679 at 2022-09-22 17:43:

## sw/BUILD/O2-latest/log
274/452 Test #298: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.17 sec
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 452
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-21T09:51:13Z

Error while checking build/O2/o2-dataflow-cs8 for becc679 at 2022-09-21 11:51:

## sw/BUILD/O2-latest/log
284/427 Test #295: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.52 sec
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 427
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-21T10:14:57Z

Error while checking build/AliceO2/O2/o2/macOS for becc679 at 2022-09-21 12:14:

## sw/BUILD/O2-latest/log
287/449 Test #295: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.22 sec
/System/Volumes/Data/build/nomad/alloc/f7552d80-4750-bbd0-a1cd-d8b3785f2966/ci/local/o2/sw/SOURCES/O2/9881/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx:372: �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/System/Volumes/Data/build/nomad/alloc/f7552d80-4750-bbd0-a1cd-d8b3785f2966/ci/local/o2/sw/SOURCES/O2/9881/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx:372: �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 449
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-21T10:30:32Z

Error while checking build/AliceO2/O2/o2/macOS-arm for becc679 at 2022-09-21 12:30:

## sw/BUILD/O2-latest/log
293/449 Test #295: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.31 sec
/System/Volumes/Data/build/nomad/alloc/627e7c3c-41b1-6bbb-b5b0-3fab21115acf/ci/local/o2/sw/SOURCES/O2/9881/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx:372: �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/System/Volumes/Data/build/nomad/alloc/627e7c3c-41b1-6bbb-b5b0-3fab21115acf/ci/local/o2/sw/SOURCES/O2/9881/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx:372: �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 449
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-21T11:15:03Z

Error while checking build/O2/o2 for becc679 at 2022-09-22 08:23:

## sw/BUILD/O2-latest/log
286/450 Test #296: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.31 sec
/sw/SOURCES/O2/9881-slc7_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/sw/SOURCES/O2/9881-slc7_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 450
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-21T12:06:44Z

Error while checking build/O2/o2-dataflow for becc679 at 2022-09-21 14:06:

## sw/BUILD/O2-latest/log
284/427 Test #295: Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx ..................***Failed    0.26 sec
/sw/SOURCES/O2/9881-slc7_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V0>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
/sw/SOURCES/O2/9881-slc7_x86-64/0/Detectors/MUON/MCH/Raw/Decoder/src/testUserLogicEndpointDecoder.cxx(370): �[1;31;49merror: in "o2_mch_raw/userlogicdsdecoder/SyncInTheMiddleChargeSumModeTwoChannels<V1>": check r == "S361-J6-DS2-ch-63-ts-345-q-123456-cs-789\n" "S361-J6-DS2-ch-63-ts-346-q-789012-cs-345\n" has failed [S361-J6-DS2-ch-63-ts-345-q-123456-cs-789
99% tests passed, 1 tests failed out of 427
100% tests passed, 0 tests failed out of 102

Full log here.

alibuild · 2022-09-22T03:30:57Z

Error while checking build/O2/fullCI for becc679 at 2022-09-22 09:36:

## sw/BUILD/o2checkcode-latest/log
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/Common/test/testGPUsortCUDA.cu:22:10: error: 'boost/test/unit_test.hpp' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:37:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/Base/GPUReconstruction.cxx:37:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/Base/GPUReconstructionCPU.cxx:45:10: error: 'omp.h' file not found [clang-diagnostic-error]
EM=1" "-D" "FMT_LOCALE" "-D" "FMT_SHARED" "-D" "GENERATORS_WITH_HEPMC3" "-D" "GENERATORS_WITH_PYTHIA6" "-D" "GENERATORS_WITH_PYTHIA8" "-D" "GPUCA_BUILD_QA" "-D" "GPUCA_GPULIBRARY=CUDA" "-D" "GPUCA_GPUTYPE_AMPERE" "-D" "GPUCA_HAVE_O2HEADERS" "-D" "GPUCA_O2_LIB" "-D" "GPUCA_TPC_GEOMETRY_O2" "-D" "O2lib_GPUTrackingCUDA_EXPORTS" "-D" "WITH_OPENMP" "-D" "ZDC_FASTSIM_ONNX" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/Base/src" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/TRD/base/src" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/DataFormats/Reconstruction/src" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/Definitions" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/DataTypes" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/Base" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/SliceTracker" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/TPCConvert" "-I" "/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/dEdx" "-I" "/sw/SOURCES/O2/9881-slc8/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/display/GPUDisplay.cxx:36:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUTracking/Base/cuda/GPUReconstructionCUDAGenRTC.cu:16:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/cuda/../Shared/Utils.h:26:10: error: 'boost/program_options.hpp' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/cuda/../Shared/Utils.h:26:10: error: 'boost/program_options.hpp' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Framework/Logger/include/Framework/Logger.h:14:10: error: 'fairlogger/Logger.h' file not found [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:520:12: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1059:69: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1175:5: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1852:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:2276:18: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:4336:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/sm_20_atomic_functions.h:89:39: error: redefinition of 'atomicAdd' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/../Shared/Utils.h:146:34: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/benchmark.hip.cxx:199:35: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/../Shared/Utils.h:146:34: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:8: error: unknown type name '__host__' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:27: error: expected ';' after top level declarator [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:33: error: overloaded 'operator+=' must have at least one parameter of class or enumeration type [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:44: error: unknown type name 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:53: error: unknown type name 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:66:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:66:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:67:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:67:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:68:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:68:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:69:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:69:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:85:1: error: unknown type name '__global__' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:19: error: use of undeclared identifier 'blockIdx' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:32: error: use of undeclared identifier 'blockDim' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:45: error: use of undeclared identifier 'threadIdx' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:78: error: use of undeclared identifier 'blockDim' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Framework/Logger/include/Framework/Logger.h:14:10: error: 'fairlogger/Logger.h' file not found [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:520:12: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1059:69: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1175:5: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1852:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:2276:18: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:4336:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/sm_20_atomic_functions.h:89:39: error: redefinition of 'atomicAdd' [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:35:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:35:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:35:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/9881-slc8_x86-64/0/Detectors/TOF/calibration/src/TOFChannelCalibrator.cxx:23:10: error: 'omp.h' file not found [clang-diagnostic-error]

Full log here.

alibuild · 2022-09-22T20:39:12Z

Error while checking build/O2/fullCI for 59697c0 at 2022-10-03 07:17:

No log files found

Full log here.

alibuild · 2022-09-22T23:03:39Z

Error while checking build/O2/o2-cs8 for 59697c0 at 2022-10-01 09:06:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 457
100% tests passed, 0 tests failed out of 102


## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/9881-slc8_x86-64-local1/include/SimulationDataFormat/MCTrack.h:24:10: fatal error: TMCProcess.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2022-09-23T03:09:42Z

Error while checking build/O2/o2 for 59697c0 at 2022-10-04 15:46:

## sw/BUILD/Monitoring-latest/log
100% tests passed, 0 tests failed out of 8

Full log here.

alibuild · 2022-09-24T13:32:15Z

Error while checking build/O2/o2-dataflow for 59697c0 at 2022-10-03 11:51:

No log files found

Full log here.

alibuild · 2022-09-27T14:13:16Z

Error while checking build/AliceO2/O2/o2/macOS-arm for 59697c0 at 2022-09-29 20:58:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 456
 76/103 Test  #90: test_Framework_test_CallbackService .....................***Failed    3.87 sec
[ERROR] pid 97577 (dest) crashed with 1
[ERROR] SEVERE: Device dest (97577) returned with 1
99% tests passed, 1 tests failed out of 102

Full log here.

alibuild · 2022-09-28T17:46:20Z

Error while checking build/O2/o2-dataflow-cs8 for 59697c0 at 2022-10-01 04:23:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 434
 92/106 Test #106: test_Framework_test_SingleDataSource ....................***Failed    3.04 sec
[ERROR] pid 25563 (internal-dpl-injected-dummy-sink) crashed with 1
[ERROR] SEVERE: Device internal-dpl-injected-dummy-sink (25563) returned with 1
99% tests passed, 1 tests failed out of 102

Full log here.

alibuild · 2022-09-28T18:21:06Z

Error while checking build/AliceO2/O2/o2/macOS for 59697c0 at 2022-09-28 20:21:

No log files found

Full log here.

aphecetche · 2022-09-30T14:24:24Z

@aferrero2707 I assume this one is a) ready to be merged (no more updates to come ?) b) can be squashed ? Let me know.

aferrero2707 · 2022-10-01T10:26:07Z

@aphecetche yes, ready to be squashed and merged! The CI failures seem to have nothing to do with the changes in this PR...

- badly formatted SYNC words - SAMPA packet headers consistency - chip address and e-link index compatibility - num of 10-bit words multiple of 4 in cluster sum mode

This is because the corresponding "Bad digit time" error type has been removed, because it is redundant. The digit time can be checked offline with `digit.getTime() != DataDecoder::tfTimeInvalid`

aferrero2707 · 2022-10-05T07:45:52Z

@aphecetche I found a small bug in the HB packets handler, see last commit. If it's ok for you could you re-approve the PR? Thanks!

aferrero2707 requested a review from a team as a code owner September 21, 2022 08:07

aferrero2707 force-pushed the mch-improve-raw-decoder-diagnostics branch from 57a968f to becc679 Compare September 21, 2022 08:16

aphecetche previously approved these changes Sep 30, 2022

View reviewed changes

aphecetche enabled auto-merge (squash) October 3, 2022 13:51

aferrero2707 added 8 commits October 4, 2022 21:38

[MCH] improved detection of TimeFrame start

a14a83a

[MCH] improved error detection in raw decoder

b1b377d

- badly formatted SYNC words - SAMPA packet headers consistency - chip address and e-link index compatibility - num of 10-bit words multiple of 4 in cluster sum mode

[MCH] removed check of digits time in DataDecoder

3039213

This is because the corresponding "Bad digit time" error type has been removed, because it is redundant. The digit time can be checked offline with `digit.getTime() != DataDecoder::tfTimeInvalid`

[MCH] skip HB decoding when not needed

846f3b8

[MCH] fixed clang formatting

b15f1c7

[MCH] added detection of mis-placed SYNC packet

b03f092

[MCH] corrected typo

7f9037c

[MCH] send HB packets regardless of mTimeRecoMode value

22d4fdb

auto-merge was automatically disabled October 4, 2022 19:41
Head branch was pushed to by a user without write access

aferrero2707 dismissed aphecetche’s stale review via 22d4fdb October 4, 2022 19:41

aferrero2707 force-pushed the mch-improve-raw-decoder-diagnostics branch from 59697c0 to 22d4fdb Compare October 4, 2022 19:41

aphecetche approved these changes Oct 5, 2022

View reviewed changes

aphecetche merged commit 6ee924d into AliceO2Group:dev Oct 5, 2022

aferrero2707 deleted the mch-improve-raw-decoder-diagnostics branch October 6, 2022 08:06

Uh oh!

Conversation

aferrero2707 commented Sep 21, 2022

Uh oh!

alibuild commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 21, 2022

Uh oh!

alibuild commented Sep 21, 2022

Uh oh!

alibuild commented Sep 21, 2022

Uh oh!

alibuild commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 21, 2022

Uh oh!

alibuild commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 28, 2022

Uh oh!

aphecetche commented Sep 30, 2022

Uh oh!

aferrero2707 commented Oct 1, 2022

Uh oh!

aferrero2707 commented Oct 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

alibuild commented Sep 21, 2022 •

edited

Loading

alibuild commented Sep 21, 2022 •

edited

Loading

alibuild commented Sep 22, 2022 •

edited

Loading

alibuild commented Sep 22, 2022 •

edited

Loading

alibuild commented Sep 22, 2022 •

edited

Loading

alibuild commented Sep 23, 2022 •

edited

Loading

alibuild commented Sep 24, 2022 •

edited

Loading

alibuild commented Sep 27, 2022 •

edited

Loading

alibuild commented Sep 28, 2022 •

edited

Loading