Skip to content

[O2B-1361] Remove DPL notion from detectors - #1991

Open
xsalonx wants to merge 13 commits into
mainfrom
xsalonx/O2B-1361/remove-dpl-notion-from-detectors
Open

xsalonx wants to merge 13 commits into
mainfrom
xsalonx/O2B-1361/remove-dpl-notion-from-detectors

Conversation

@xsalonx

@xsalonx xsalonx commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Replace dplDetectorId in RCT URLs and API by detectorId

Notable changes for developers:

  • Remove DPL notion from RCT code

Changes made to the database:

  • NA

@codecov

codecov Bot commented Sep 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.58824% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.69%. Comparing base (4391066) to head (b3a4b10).

Files with missing lines Patch % Lines
...lic/views/QcFlags/Overview/QcFlagsOverviewModel.js 0.00% 14 Missing ⚠️
...public/views/QcFlags/details/QcFlagDetailsModel.js 0.00% 11 Missing ⚠️
.../ActiveColumns/runDetectorsAsyncQcActiveColumns.js 0.00% 11 Missing ⚠️
lib/public/views/QcFlags/QcFlagsModel.js 0.00% 8 Missing ⚠️
...ic/views/QcFlags/details/qcFlagDetailsComponent.js 0.00% 4 Missing ⚠️
...ews/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js 0.00% 2 Missing ⚠️
lib/public/Model.js 0.00% 1 Missing ⚠️
...blic/components/qcFlags/qcFlagOverviewPanelLink.js 0.00% 1 Missing ⚠️
...ervices/detectors/remoteDetectorUserHasAccessTo.js 0.00% 1 Missing ⚠️
...ags/Synchronous/SynchronousQcFlagsOverviewModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
- Coverage   46.23%   44.69%   -1.54%     
==========================================
  Files        1039     1039              
  Lines       17142    17142              
  Branches     3124     3124              
==========================================
- Hits         7925     7662     -263     
- Misses       9217     9480     +263     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx
xsalonx marked this pull request as ready for review September 24, 2025 00:12
@xsalonx
xsalonx requested a review from graduta as a code owner September 24, 2025 00:12
@graduta graduta changed the title [O2B-1361] Remote DPL notion from detectors [O2B-1361] Remove DPL notion from detectors Sep 24, 2025
@graduta
graduta requested a review from isaachilly as a code owner July 29, 2026 09:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants