Changes the composition, second try - #1036
Merged
Merged
Conversation
rbailhac
requested review from
benedikt-voelkel,
chiarazampolli,
gconesab and
sawenzel
as code owners
April 26, 2023 12:38
|
|
||
| #generate random number | ||
| RNDSIG=$((1 + $RANDOM % 100)) | ||
| RNDSIG=$((0 + $RANDOM % 100)) |
Contributor
There was a problem hiding this comment.
you could even remove the 0 + from the calculation. That does not do anything
Contributor
Author
There was a problem hiding this comment.
Should be done now.
Contributor
There was a problem hiding this comment.
great! Let's wait for the CI and then I think we can merge it.
benedikt-voelkel
approved these changes
Apr 26, 2023
rmunzer
pushed a commit
to rmunzer/O2DPG
that referenced
this pull request
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try. Sorry, for technical reasons I had to close the previous pull request.