AODBcRewriter : remapping matching indices in O2fwdtrack table - #2418
Closed
mcoquet642 wants to merge 1 commit into
Closed
AODBcRewriter : remapping matching indices in O2fwdtrack table#2418mcoquet642 wants to merge 1 commit into
mcoquet642 wants to merge 1 commit into
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
3 tasks
sawenzel
added a commit
that referenced
this pull request
Jul 28, 2026
…098) Stage 1b (added in #2370) reorders O2track_iu/O2mfttrack/O2fwdtrack to keep the "-1" ambiguous group contiguous, but wrote each table as soon as it was planned. O2fwdtrack references O2mfttrack (reordered later in the same loop) and itself (fIndexFwdTracks_MatchMCHTrack); neither permutation existed yet at write time, so both columns kept pre-reorder row numbers -- in range, so AODBcRewriterValidate passed, while every global muon got a foreign MFT/MCH leg (Maurice Coquet, sameParticle=0 on an anchored pO sample; patch proposal #2418). This fires whenever Stage 1b's regroup runs, independent of any BC/collision reorder, so every merged MC AO2D since 4 Jun is affected. Fix: * kIndexRefs: one registry of "which fIndex* column points at which table", used by the rewriter, the validator, and a new drift guard (an unregistered fIndex* column now fails the test instead of silently mis-linking data). * buildRemaps() derives a table's full remap set from that registry; the old "primary index + optional extras" split in rewriteTable is gone, so a stage can no longer forget a column the way Stage 1b forgot O2fwdtrack's. * Planning and writing are separate phases: every stage publishes its row permutation before anything is written, so forward/self references resolve correctly. New AODBcRewriterCheckLinks(in, out): fingerprints each row's non-index payload and checks, per table, that (row, referenced row) pairs survive the rewrite -- the only check that can see this bug class, since the corrupted indices were structurally valid. Needs only the input file, so it also runs on real production AO2Ds. MC/utils/tests/ adds the executable test this tool never had: a synthetic AO2D covering every pathology (duplicate/non-monotonic BCs, duplicate MC collisions, split -1 groups, fwd<->MFT and fwd->fwd references, ...), driven by run_aodbcrewriter_tests.sh -- ROOT only, seconds to run, nothing binary committed. Verified against the pre-fix rewriter and a real anchored pp production (run 553185, LHC24al apass1): sameParticle collapses to 0 with the shipped code and is fully restored with this fix, in every scenario tested, including one engineered to contain genuine duplicate BCs. Diagnosis and original patch: Maurice Coquet (#2418). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Changes incorporated in larger fix. Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reordering of O2fwdtrack table in AODBcRewriter Stage 1b does not remap the indices fIndexMFTTracks and fIndexFwdTracks_MatchMCHTrack. This PR defer writing O2fwdtrack and remap mathcing indices using MFT/Fwd PermMaps.