MFT: New json parameters added - #571
Merged
knopers8 merged 3 commits intoAug 15, 2022
Merged
Conversation
tomas-herman
requested review from
benedikt-voelkel,
chiarazampolli,
davidrohr,
gconesab,
martenole,
sawenzel and
shahor02
as code owners
August 12, 2022 13:34
knopers8
reviewed
Aug 12, 2022
| "maxDuration" : "60000", | ||
| "timeBinSize" : "0.1", | ||
| "ROFLengthInBC" : "198", | ||
| "geomFileName" : "/home/epn/odc/files/o2sim_geometry-aligned.root" |
Collaborator
There was a problem hiding this comment.
i am not sure if MC is ran with this file at this location
Contributor
Author
There was a problem hiding this comment.
I have removed the full path and left only the file name.
knopers8
approved these changes
Aug 12, 2022
chiarazampolli
approved these changes
Aug 12, 2022
Collaborator
|
This unfortunately does not work with the FST: Maybe you can take a look at how the other detectors do? |
Contributor
Author
|
Looking both at the json files in the MC folder and in the qc-sync folder everyone is using the geometry file name without the full path. MC QC of ITS-TPC matching: Sync QC of ITS-TPC-TOF: So I have removed the full path and in all cases it is just the file name now. Let's see if the test is ok now. |
Collaborator
|
it looks ok now |
rmunzer
pushed a commit
to rmunzer/O2DPG
that referenced
this pull request
Sep 20, 2022
* MFT: New json parameters added * Remove full path to geometry file * Removing the full geometry file path also from qs sync json files
rmunzer
pushed a commit
to rmunzer/O2DPG
that referenced
this pull request
Oct 14, 2022
* MFT: New json parameters added * Remove full path to geometry file * Removing the full geometry file path also from qs sync json files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.