Skip to content

[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc#10860

Merged
fgrosa merged 13 commits into
AliceO2Group:masterfrom
mfaggin:addSc2520
Apr 23, 2025
Merged

[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc#10860
fgrosa merged 13 commits into
AliceO2Group:masterfrom
mfaggin:addSc2520

Conversation

@mfaggin

@mfaggin mfaggin commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • add MC matching for Sc(2520) in candidate creator
  • add event selection for generated Sc
  • propagate modifications to the Sc task
  • add the PR in O2 adding the Sc0(2520) and Sc++(2520) (Add SigmaC(2520). AliceO2#14187)

@mfaggin

mfaggin commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator Author

@Mingyu3360715

@github-actions github-actions Bot changed the title PWGHF: add MC matching for Sc(2520) and add ev. sel. for generated Sc [PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc Apr 15, 2025
@alibuild alibuild mentioned this pull request Apr 16, 2025
Closed
@mfaggin

mfaggin commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator Author

@Mingyu3360715 this PR looks ready to go to me. I open it for the review.

@mfaggin mfaggin marked this pull request as ready for review April 22, 2025 14:52
@alibuild

alibuild commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 0cd576f at 2025-04-22 17:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx:480:83: error: 'kSigmaCStar0' is not a member of 'o2::constants::physics::Pdg'
/sw/SOURCES/O2Physics/10860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx:501:83: error: 'kSigmaCStarPlusPlus' is not a member of 'o2::constants::physics::Pdg'
/sw/SOURCES/O2Physics/10860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx:577:67: error: 'kSigmaCStar0' is not a member of 'o2::constants::physics::Pdg'
/sw/SOURCES/O2Physics/10860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx:589:74: error: 'kSigmaCStarPlusPlus' is not a member of 'o2::constants::physics::Pdg'
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Apr 22, 2025
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfaggin , thanks for the great code improvements. Please see my suggestions.

Comment thread PWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment thread PWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment thread PWGHF/DataModel/CandidateReconstructionTables.h Outdated
Comment thread PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx Outdated
Comment thread PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx Outdated
Comment thread PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx Outdated
@mfaggin

mfaggin commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @vkucera, thanks a lot for the suggestions. They are implemented now.

@vkucera

vkucera commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Hi @vkucera, thanks a lot for the suggestions. They are implemented now.

Thanks @mfaggin for addressing the suggestions.

@fgrosa fgrosa merged commit dc45a50 into AliceO2Group:master Apr 23, 2025
@mfaggin mfaggin deleted the addSc2520 branch April 23, 2025 12:51
bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025
@mfaggin @bghanley1995
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
fc50c56 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@mfaggin @jinhyunni
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
dac7c57 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@mfaggin @jinhyunni
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
5786cf8 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@mfaggin
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
f330704 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@mfaggin @ariedel-cern
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
5b2bb05 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@mfaggin @smaff92
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
86f0a04 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@mfaggin @CesarOmarRA
[PWGHF] add MC matching for Sc(2520) and add ev. sel. for generated Sc (
f2e93de 
AliceO2Group#10860)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfaggin @alibuild @vkucera @fgrosa