PWGEM/PhotonMeson: Add Background calculation to pi0QC task - #1597
Merged
Conversation
jokonig
commented
Dec 6, 2022
jokonig
commented
Collaborator
- Add mixed events and rotation background calculation
- Fix loop over collisions instead of whole timeframes
- Added opening angle cut
jokonig
requested review from
alibuild,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
December 6, 2022 12:15
jokonig
force-pushed
the
master
branch
2 times, most recently
from
December 6, 2022 12:59
239ae7c to
bbc3027
Compare
Collaborator
Author
|
I had a look into the MegaLinter output as it fails. It seems that the failure is caused by other tasks and not by mine |
Collaborator
|
Error while checking build/O2Physics/o2 for bbc3027 at 2022-12-06 15:15: Full log here. |
- Add mixed events and rotation background calculation - Fix loop over collisions instead of whole timeframes - Added opening angle cut
Collaborator
Author
|
@mikesas @m-c-danisch could you approve this PR? |
mikesas
approved these changes
Dec 9, 2022
MrWhatZitToYaa
pushed a commit
to MrWhatZitToYaa/O2Physics
that referenced
this pull request
Dec 20, 2022
…roup#1597) - Add mixed events and rotation background calculation - Fix loop over collisions instead of whole timeframes - Added opening angle cut
ercolessi
pushed a commit
to ercolessi/O2Physics
that referenced
this pull request
Jan 9, 2023
…roup#1597) - Add mixed events and rotation background calculation - Fix loop over collisions instead of whole timeframes - Added opening angle cut
GijsvWeelden
pushed a commit
to GijsvWeelden/O2Physics
that referenced
this pull request
Jan 13, 2023
…roup#1597) - Add mixed events and rotation background calculation - Fix loop over collisions instead of whole timeframes - Added opening angle cut
cimordas
pushed a commit
to cimordas/O2Physics
that referenced
this pull request
Jan 20, 2023
…roup#1597) - Add mixed events and rotation background calculation - Fix loop over collisions instead of whole timeframes - Added opening angle cut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.