[PWGHF] Fix D0 ML prompt and non-prompt score ordering#17173
Merged
zhangbiao-phy merged 1 commit intoJul 23, 2026
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
zhangbiao-phy
marked this pull request as ready for review
July 22, 2026 16:53
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
xinyepeng
as code owners
July 22, 2026 16:53
Collaborator
|
Error while checking build/O2Physics/code-check for 2167cb7 at 2026-07-22 19:31: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 2167cb7 at 2026-07-23 09:34: Full log here. |
Contributor
|
Hi @zhangbiao-phy , thanks a lot for the implementation! It looks good to me. As you tagged all the D0 analysers, just a reminder, the order of the BDT responses is also related to that used in local training. That's saying the order in local training should also be:
|
zhangbiao-phy
enabled auto-merge (squash)
July 23, 2026 13:04
alibuild
approved these changes
Jul 23, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
Collaborator
|
@zhangbiao-phy Please keep in mind that D0 task users are just a subset of the ML response users. If I understand correctly, this affects everyone who applies ML cuts on D0 selection, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received several reports from different analysers about the D0 BDT score ordering, which has caused some confusion.
This PR fixes the D0 ML score class ordering used in the D0 task and ML response helper.
The D0 ML output vector follows the common charm-hadron convention:
The previous code interpreted indices 1 and 2 as non-prompt and prompt in some places. This update aligns the D0 ML feature mapping and THnSparse axis ordering with the model output convention and with the convention used by other charm-hadron tasks.
The ML selection cut directions are unchanged. For
o2-analysis-hf-candidate-selector-d0,cutDirMlshould remain:i.e.
cutDirMl = 0,1,1.Tagging D0 task users: @Mingyu3360715 @wuctlby @xinyepeng @kgwizdzi @atavirag
Please let me know if you have any comments on this! Thanks a lot!