Skip to content

[PWGDQ] Add MC truth information and configurable tag#17182

Open
dmallick2 wants to merge 3 commits into
AliceO2Group:masterfrom
dmallick2:master
Open

[PWGDQ] Add MC truth information and configurable tag#17182
dmallick2 wants to merge 3 commits into
AliceO2Group:masterfrom
dmallick2:master

Conversation

@dmallick2

Copy link
Copy Markdown
Collaborator

--Add Missing kMCMass map in VariableManger.cxx
--Fix some configurable tag options for read only truth level output on particular analysis , not store all lead to memory issue in dqEfficiency_withAssoc_direct.cxx
-- Add truth level histograms for PbPb in HistogramsLibrary.cxx

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 311 errors, ⚠️ 181 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title PWGDQ: Add MC truth information and configurable tag [PWGDQ] Add MC truth information and configurable tag Jul 23, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 955e5e2 at 2026-07-23 14:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:1530:31: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2213:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2216:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2213:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2216:54: error: too many arguments for format [-Werror=format-extra-args]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 955e5e2 at 2026-07-23 14:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 122 errors and 8 warnings.'
Found 122 errors and 8 warnings.
++ [[ 122 -gt 0 ]]
++ cat /sw/BUILD/755bbefcca3df02d8745241b68644c1e695e6806/O2Physics-code-check/errors.txt
PWGDQ/Core/HistogramsLibrary.cxx:1276:137: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1283:137: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:47:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:50:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:80:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:134:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:195:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:196:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:274:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:275:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:295:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:41: error: variable 'calibStatus' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:324:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:325:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:326:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:346:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:347:66: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:348:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:349:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:369:7: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:403:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:414:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:434:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:22: error: variable 'binCenter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:315:8: error: constructor does not initialize these fields: fEventCut, fCCDB, fCurrentRun [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:373:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:373:65: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:411:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:439:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 955e5e2 at 2026-07-23 18:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:1530:31: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2213:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2216:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2213:54: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:2216:54: error: too many arguments for format [-Werror=format-extra-args]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c59d08b at 2026-07-23 19:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 121 errors and 8 warnings.'
Found 121 errors and 8 warnings.
++ [[ 121 -gt 0 ]]
++ cat /sw/BUILD/8618efa1163f3117ceb163c271ab518db1dac766/O2Physics-code-check/errors.txt
PWGDQ/Core/HistogramsLibrary.cxx:1276:137: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/HistogramsLibrary.cxx:1283:137: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:47:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:50:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:80:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:134:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:195:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:196:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:274:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:275:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:295:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:41: error: variable 'calibStatus' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:324:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:325:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:326:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:346:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:347:66: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:348:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:349:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:369:7: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:403:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:414:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:434:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:22: error: variable 'binCenter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:315:8: error: constructor does not initialize these fields: fEventCut, fCCDB, fCurrentRun [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:373:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:373:65: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:411:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:439:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants