Skip to content

[PWGLF] First attempt at V0 reconstruction using MFT only - #17325

Merged
lhusova merged 8 commits into
masterfrom
ForwardV0s
Aug 6, 2026
Merged

[PWGLF] First attempt at V0 reconstruction using MFT only#17325
lhusova merged 8 commits into
masterfrom
ForwardV0s

Conversation

@romainschotter

@romainschotter romainschotter commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

First attempt at V0 reconstruction using MFT-only tracks

@ddobrigk @MauriceCoke for your information

@github-actions github-actions Bot added the pwglf label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 13 errors, ⚠️ 14 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title First attempt at V0 reconstruction using MFT only [PWGLF] First attempt at V0 reconstruction using MFT only Aug 4, 2026
@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ed51b6d at 2026-08-06 07:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 55 warnings.'
Found 30 errors and 55 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/97635d9a3ef05c86921520f9842193c179083aa9/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:31:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:37:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:53:1: error: included header DataTypes.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:62:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:64:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:66:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:68:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:84:27: error: no header providing "ROOT::Math::SVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:31: error: no header providing "ROOT::Math::SMatrix" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:65: error: no header providing "ROOT::Math::MatRepSym" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:89:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:90:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:101:8: error: constructor does not initialize these fields: ccdb, mRunNumber, magField, lut, maskTopological, maskTrackProperties, maskK0ShortSpecific, maskLambdaSpecific, maskAntiLambdaSpecific, maskD0Specific, maskAntiD0Specific, maskSelectionK0Short, maskSelectionLambda, maskSelectionAntiLambda, maskSelectionD0, maskSelectionAntiD0, secondaryMaskSelectionLambda, secondaryMaskSelectionAntiLambda [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:157:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:183:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:301:13: error: no header providing "o2::base::MatLayerCylSet" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:371:52: error: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1029:45: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1051:17: error: no header providing "o2::base::Propagator" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1889:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1949:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1988:34: error: no header providing "o2::track::TrackParCovFwd" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1993:12: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2098:7: error: no header providing "TVector3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2257:92: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2485:148: error: no header providing "o2::aod::CentNGlobals" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2485:167: error: no header providing "o2::aod::CentFV0As" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2485:183: error: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2485:199: error: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2485:215: error: no header providing "o2::aod::CentFT0CVariant1s" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/97635d9a3ef05c86921520f9842193c179083aa9/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:696:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:698:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:700:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:702:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:704:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1231:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1236:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1241:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1246:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1251:32: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@lhusova
lhusova enabled auto-merge (squash) August 6, 2026 06:00
@lhusova
lhusova merged commit 24bc414 into master Aug 6, 2026
11 of 15 checks passed
@lhusova
lhusova deleted the ForwardV0s branch August 6, 2026 06:00
@vkucera

vkucera commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

@romainschotter @lhusova Why was this merged despite errors???

@vkucera

vkucera commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

@romainschotter

  • Please stop polluting the central repository with your personal branches.
  • Pay attention to whom you tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants