Skip to content

[PWGDQ] various improvements to the global alignment task histograms - #17743

Merged
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-decay-length-plots
Sep 7, 2026
Merged

[PWGDQ] various improvements to the global alignment task histograms#17743
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-decay-length-plots

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor
  • added histograms for di-muon decay lengths
  • added possibility to modify some of the histogram axis definitions via configurable options
  • added option that reduces the size of MFT DCA histograms (enabled by default)

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 68 warnings, 🔕 5 disabled

mguilbau
mguilbau previously approved these changes Sep 3, 2026
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-decay-length-plots branch from f62a2c8 to 8ee1ec8 Compare September 3, 2026 08:23
@aferrero2707
aferrero2707 marked this pull request as ready for review September 3, 2026 08:29
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8ee1ec8 at 2026-09-03 15:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 0 warnings.'
Found 10 errors and 0 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/3f3c338eb856de4cb9699b61fdbfdaed2a162484/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:59:1: error: included header Vector3D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:60:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:313:18: error: no header providing "o2::vertexing::FwdDCAFitterN" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:354:10: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:361:10: error: no header providing "std::stringstream" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:366:7: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1213:12: error: slicing object from type 'GlobalFwdTrack' to 'TrackParCovFwd' discards 40 bytes of state [cppcoreguidelines-slicing,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1649:15: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1668:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1687:8: error: no header providing "std::optional" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

@aferrero2707
aferrero2707 marked this pull request as draft September 3, 2026 19:27
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-decay-length-plots branch from 8ee1ec8 to 23e3ade Compare September 6, 2026 11:31
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-decay-length-plots branch from 23e3ade to 059f4d1 Compare September 6, 2026 11:35
@aferrero2707
aferrero2707 marked this pull request as ready for review September 6, 2026 20:51
@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 059f4d1 at 2026-09-06 23:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 1 warnings.'
Found 4 errors and 1 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/8992a9623650db366b284caa505292af0fbda8f1/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:60:1: error: included header Vector3D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:61:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1653:15: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1672:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/8992a9623650db366b284caa505292af0fbda8f1/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:93:10: warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@aferrero2707

Copy link
Copy Markdown
Contributor Author

@mcoquet642 I have added the L_z plots to the muon alignment analysis code, to better monitor the impact of new geometries on the DCA resolution.
Could you please have a look? There are also some changes related to the MFT DCA histograms configuration, that are unrelated.
Thanks a lot!

Comment thread PWGDQ/Tasks/muonGlobalAlignment.cxx Outdated
* added histograms for di-muon decay lengths
* added possibility to modify some of the histogram axis definitions
  via configurable options
* added option that reduces the size of MFT DCA histograms (enabled by default)
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-decay-length-plots branch from 059f4d1 to ac284ad Compare September 7, 2026 09:16
@aferrero2707

Copy link
Copy Markdown
Contributor Author

@mcoquet642 I have made the two-prong fitter parameters configurable as suggested.

@mcoquet642
mcoquet642 merged commit 2743326 into AliceO2Group:master Sep 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants