[PWGHF] Remove unnecessary caching of feature names in HF track index skim creator

[fgrosa]

This PR removes the unnecessary caching of feature names, which is incompatible with https://github.com/AliceO2Group/O2Physics/pull/17192/changes

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 8 warnings, 🔕 7 disabled

[alibuild]

Auto-approving on behalf of @fgrosa.

[vkucera]

@fgrosa The linked PR did not change any functionality. How can it be the reason for this PR?

[fgrosa]

@fgrosa The linked PR did not change any functionality. How can it be the reason for this PR?

If you try to execute the track index skim creator now with BDTs applied, you will get the following error:

[ERROR] SEVERE: Device hf-track-index-skim-creator (21008) had at least one message above severity 7: Input feature ptProng0 not available! Please check your configurables.

See e.g. https://alimonitor.cern.ch/train-workdir/tests/0075/00755074/stdout.log. I assumed that the issue was in the change of the check in cacheInputFeaturesIndices, since it was not happening before (and it makes sense because mAvailableInputFeatures.contains(inputFeature) cannot be true, as we do not pass the features via configurables given that they are fixed).

[alibuild]

Error while checking build/O2Physics/code-check for 80e02b8 at 2026-09-07 14:25:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 39 errors and 27 warnings.'
Found 39 errors and 27 warnings.
++ [[ 39 -gt 0 ]]
++ cat /sw/BUILD/da4548d66b33dde722b086532bcbae6ae9a229c7/O2Physics-code-check/errors.txt
PWGHF/TableProducer/trackIndexSkimCreator.cxx:177:42: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:177:55: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:178:25: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:179:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:312:76: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:317:76: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:322:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:327:84: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:337:74: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:342:87: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:343:95: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:345:71: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1426:68: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1429:70: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1432:74: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1435:78: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1438:70: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1441:70: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1444:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1447:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1450:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1453:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1456:72: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1459:76: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1476:77: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1478:92: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1479:102: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1480:94: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1481:94: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:1482:96: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2088:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2462:17: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2594:27: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2628:15: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2857:23: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:2886:23: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:3132:23: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:3161:23: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGHF/TableProducer/trackIndexSkimCreator.cxx:4195:17: error: uninitialized record type: 'dcaInfoXi' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/da4548d66b33dde722b086532bcbae6ae9a229c7/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/trackIndexSkimCreator.cxx:171:43: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

[fcatalan92]

I think the behavior of mAvailableInputFeatures.contains(inputFeature) is very similar to that previously implemented with mAvailableInputFeatures.count(inputFeature). Maybe the path now crashing in the index-skim-creator was never run before or using count the check was not effective.
In any case, the current behavior of MlResponse is what we want, so all looks sane to me.

[fcatalan92]

BTW, after some investigation, the changes in this PR remove the workaround implemented in #16719 for the issue introduced by #16424 and fixed in #16722. Again, all makes sense.