Skip to content

[PWGCF] Net charge fluctuations3 - #17825

Open
pravatp98 wants to merge 17 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3
Open

[PWGCF] Net charge fluctuations3#17825
pravatp98 wants to merge 17 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

Conversation

@pravatp98

Copy link
Copy Markdown
Contributor

Updated For Pt ranged for kaon and proton

Updated for  efficiency correction and sub-sampling
…ficiency correction

Refactor identification bits to use constexpr instead of #define, update includes to comment out unused headers, and improve readability of various functions.
Commented out unused identification bits for clarity.
Added configurable pT cutoffs for kaons and protons, and updated relevant sections to use these cutoffs for efficiency corrections.
@github-actions github-actions Bot added the pwgcf label Sep 8, 2026
@github-actions github-actions Bot changed the title Net charge fluctuations3 [PWGCF] Net charge fluctuations3 Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8f84864 at 2026-09-08 04:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 3 warnings.'
Found 2 errors and 3 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/3c70dcdc680c06328b425d50bf1c7e4c54359cf2/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/3c70dcdc680c06328b425d50bf1c7e4c54359cf2/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1136:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1156:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1209:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b22d4cf at 2026-09-08 11:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 3 warnings.'
Found 2 errors and 3 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/d36a89e86a6e02807b56861e27ac4b0e823938e3/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d36a89e86a6e02807b56861e27ac4b0e823938e3/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1136:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1156:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1209:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants